-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regarding localization #6
Comments
I agree with your idea to include localization in the proyect but I believe we should first focus on learning about wikidata and see if it is feasible to implement localization in the question generator module. I am concerned about those questions whose entries in wikidata may be wrong or incomplete, depending on language. |
According to Wikidata's SPARQL query service documentation, both a language and a fallback language can be specified in the query. If we can't use SPARQL, then I suppose we could have two options: through REST calls or failing that, building a service exclusive to that. Regarding the latter, I suppose Wikidata-Toolkit is worth looking into, although this link shows it does not support the Wikidata Query Service. |
As SPARQL now seems to be a possible alternative, I think we should discuss which is the best approach. On my opinion, building our own service should be the last option as there are other more important things to pay attention on. |
From my point of view, localization seems like an interesting extension for the project. However, I think we should avoid doing the optional exercises until you have the system working. |
I think it's an interesting idea to be considered, but since we haven't really started to work, we should first focus on other things. |
This is a bit long as an answer but I tried to simplify and make as clear as possible. Spring Boot:This is some info about most of the libraries:They are plenty and all of them seem to use REST to query the data from wikidata's endpoint. Also, as far as I am concerned, all of them use JDBC for querying. However, due to volume I have not check on every one. Pros (for most of the libraries):
Cons:
If using Jena, which seems to be the most important library out there regarding SPARQL:First, it also uses REST so the previous point will be likely to be applied here too. It provides a library to connect to Jena SPARQL API which has lots of different capabilities. Pros:
Node.jsRegarding Node.js, there are few libraries available which have not been updated in some years. It is way simpler as it is basically an HTTP request in js. |
When adding localization to the API we should take this into account: |
I don't think the API (the schema of the data returned) should be localized, it would create problems when receiving the data that would need to be solved. I do think the results returned should be localized, though. Edit: edit due to misunderstanding |
In the Edit: the mentioned branch is waiting for review in #32. |
Since no one seems to be commenting on this right, I'll give an update. We seem to be doing somewhat alright with the localization, but we have left mocking the |
The fix for the warning of the tests has been merged in #126. |
It seems we currently have nothing left to discuss, so we may as well close this issue. |
Should we localize the application? Since we have hardly started, I think it is an optional requirement we should consider now. I have looked into it and there seem to be many React localization modules.
The text was updated successfully, but these errors were encountered: