Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed game #199

Merged
merged 18 commits into from
Apr 8, 2024
Merged

fix: fixed game #199

merged 18 commits into from
Apr 8, 2024

Conversation

dariogmori
Copy link
Contributor

  • questions working
  • statistics working
  • answers working

dariogmori added 18 commits April 8, 2024 16:01
@dariogmori
refactor: find random question and added error handling
8499be6
@dariogmori
fix: descriptive error code for illegal state
8e0fde2
@dariogmori
fix: error when asking for question with no round started
ea1b18e
@dariogmori
refactor: game vars now are long
d1a1931
@dariogmori
fix: transactional new game, new round and answer
9a3ee16
@dariogmori
fix: save statistics after game over now if game is checked
c8303bc
@dariogmori
fix: cannot change language after game over
6f9ca42
@dariogmori
test: language change when game over
fe37fc2
@dariogmori
fix: statistics are created when not there for user
fe12dca
@dariogmori
fix: statistics
b7f0e3f
@dariogmori
fix: game over
0631851
@dariogmori
fix: game can be played
84c0abc
@dariogmori
fix: game over again
334e6bc
@dariogmori
fix: answer now returns boolean
aa0b499
@dariogmori
fix: answer now returns boolean
3d9bbb2
@dariogmori
fix: user stats in game
2d66029
@dariogmori
fix: question not loading
60b2faf
@dariogmori
fix: loading after loading questions
1aa45df
@dariogmori dariogmori added this to the Third delivery milestone Apr 8, 2024
@dariogmori dariogmori requested review from jjgancfer and UO283615 April 8, 2024 21:02
@dariogmori dariogmori self-assigned this Apr 8, 2024
jjgancfer
jjgancfer approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
27.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@dariogmori dariogmori changed the title fix: fixed frontend fix: fixed game Apr 8, 2024
@UO283615 UO283615 merged commit f861fa8 into develop Apr 8, 2024
1 of 2 checks passed
@dariogmori dariogmori mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GOLASOOO GOLASOOO GOLASOOO approved these changes

@UO283615 UO283615 UO283615 approved these changes

@jjgancfer jjgancfer jjgancfer approved these changes

Assignees

@dariogmori dariogmori

Labels
None yet
Projects
None yet
Milestone
Third delivery
Development

Successfully merging this pull request may close these issues.
4 participants
@dariogmori @jjgancfer @UO283615 @GOLASOOO