feat/webapp/top bar: An initial top bar for the layout #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The unit tests are not passing, you should review the code. |
|
|
The problem was caused by dead code that was either to be removed or intended not to be run currently. It has been fixed by deleting said dead code. |
jjgancfer
requested review from
Toto-hitori and
gony02
and removed request for
Toto-hitori
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial top bar that should cover some, if not all, of the used endpoints in the front. Some initial tests, as well as localization, are also provided (there is a warning when executing them due to the localization, but for now they do work).
As it was done using Chakra UI as according to #16, the Login and Register pages have been removed and their tests commented out because they use MUI. They should be easy to rework in the new UI, though.
I have also checked why no automatic merge is possible, and it apparently is because a conflict in a .gitignore.