Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 #10

Open
KarelWintersky opened this issue Jan 28, 2025 · 0 comments
Open

2.0.0 #10

KarelWintersky opened this issue Jan 28, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@KarelWintersky
Copy link
Contributor

Нужно переделать метод group на именованные аргументы:

public static function group(array $options = [], callable $callback = null)

Должно быть

public static function group(
  string|array $before,
  string|array $after,
  string $prefix = null,
  string $namespace = null,
  callable $handler = null
)

Это даст нам более наглядную запись:

AppRouter::group(before: ..., after: ..., handler: function() {});

Подумать над тем, что миддлвар может быть записан не как строка, а как коллбэк

@KarelWintersky KarelWintersky self-assigned this Jan 28, 2025
@KarelWintersky KarelWintersky added the enhancement New feature or request label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant