Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate smart contract tests from Hardhat to Foundry. #367

Open
ryley-o opened this issue Oct 27, 2022 · 1 comment
Open

Migrate smart contract tests from Hardhat to Foundry. #367

ryley-o opened this issue Oct 27, 2022 · 1 comment
Labels
enhancement New feature or request research Still requiring more research wontfix This will not be worked on

Comments

@ryley-o
Copy link
Contributor

ryley-o commented Oct 27, 2022

This is currently a watch-item, based on Foundry adoption and/or advantages.

Goal: This will improve developer efficiency, code sharing, reliability, and code health as a function of time. No longer as urgent after previous eng work (previously tests took long time but now run in parallel and no longer take a long time).
@ryley-o ryley-o added enhancement New feature or request wontfix This will not be worked on research Still requiring more research labels Oct 27, 2022
@ryley-o
Copy link
Contributor Author

ryley-o commented Feb 23, 2023

With the changes in #498, this becomes less valuable thanks to hardhat fixtures being much more performant than our previous use of mocha's beforeEach. We can keep this issue though, since using Foundry would enable our tests to be written in solidity, and should still be considered an option, even if we are less likely to pursue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request research Still requiring more research wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryley-o