Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1984] No fun allowed PR (Holiday removal) #607

Merged

Conversation

QuacksQ
Copy link
Contributor

@QuacksQ QuacksQ commented Jul 18, 2024

About The Pull Request

1984 Calendar

This PR removes holidays.
I am making this PR for purely selfish and hateful reasons. I highly dislike that holidays alters parts of the game and maps during specific days of the year and that the game gets changed in ways that do not fit in with the setting we're going for. This was a funny gimick to have for TG but we're not them so its time to let go. Holidays no longer exist with this PR and their associated code is gone.
Among us Emergency meeting has also been killed completely, dead meme begone and this had ties with Holidays.

If there are objections to this PR I'll hear it and I'm willing to compromise on some of the removals.

How Does This Help Gameplay?

Minimal impact on gameplay.

How Does This Help Roleplay?

Actual impact on RP this time because there is no longer immersion breaking, or out of place events going on during certain days of the year. Wow immersion but for real this time. Also tile decals no longer get changed now if its pride month.

Proof of Testing

Screenshots/Videos

Its gone!

Changelog

🆑
del: Remvoved Holidays.
del: Removed Emergency meeting (Sus is no longer amogus)
/:cl:

@QuacksQ QuacksQ requested a review from RimiNosha as a code owner July 18, 2024 23:24
@github-actions github-actions bot added Config Update Oh boy, Rimi has to touch the server config when this gets merged. Mapping Something something someone placed three reinforced window spawners in one place. Removal "What is soul? Are you a cult?" Sounds Also known as "I added a background rumble to lavaland and gave everyone headaches". Sprites I like pretty things. UI Also known as "I like lagspikes, so I added TGUI to your TGUI". labels Jul 18, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Jul 26, 2024
@github-actions github-actions bot closed this Aug 2, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Aug 3, 2024
@RimiNosha RimiNosha reopened this Aug 3, 2024
@RimiNosha
Copy link
Contributor

I didn't have time to post more detailed thoughts on this at the time, but my only concerns are (can be done in later PRs):

  • Add a cargo package or two for celebrations. Can contain some generic stuff, and I'm fine with gatekeeping them behind service access.
  • Maybe get some lorecaster-type additions going, so players can look up in-game events relative to IRL dates.

I'll fix the missing xmas tree spawners.

@github-actions github-actions bot requested a review from RimiNosha October 7, 2024 21:18
@RimiNosha RimiNosha merged commit c764dd4 into Artea-Station:master Oct 7, 2024
17 checks passed
Artea-Station-Bot added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Update Oh boy, Rimi has to touch the server config when this gets merged. Mapping Something something someone placed three reinforced window spawners in one place. Removal "What is soul? Are you a cult?" Sounds Also known as "I added a background rumble to lavaland and gave everyone headaches". Sprites I like pretty things. UI Also known as "I like lagspikes, so I added TGUI to your TGUI".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants