Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing value placeholders for strings aren't checked for their encoding #45

Open
LTLA opened this issue Mar 2, 2025 · 0 comments
Open

Missing value placeholders for strings aren't checked for their encoding #45

LTLA opened this issue Mar 2, 2025 · 0 comments

Comments

@LTLA
Copy link
Member

LTLA commented Mar 2, 2025

Currently the absence of a check is harmless as HDF5 only has ASCII and UTF8 right now, and UTF8 is a superset of ASCII, so all known encodings are valid. But it might not be so in the future, so we should really use ritsuko::hdf5::is_utf8_string() to verify that the datatypes are valid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LTLA