Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin transitioning to a simpler layout for the on-disk representation. #13

Merged
merged 17 commits into from
Nov 19, 2023

Conversation

LTLA
Copy link
Member

@LTLA LTLA commented Nov 19, 2023

No description provided.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (90497fd) 98.29% compared to head (facf97e) 97.33%.
Report is 1 commits behind head on master.

Files Patch % Lines
include/takane/data_frame.hpp 94.82% 3 Missing and 3 partials ⚠️
include/takane/atomic_vector.hpp 90.19% 2 Missing and 3 partials ⚠️
include/takane/data_frame_factor.hpp 87.80% 2 Missing and 3 partials ⚠️
include/takane/simple_list.hpp 88.63% 0 Missing and 5 partials ⚠️
tests/src/utils.h 86.48% 4 Missing and 1 partial ⚠️
tests/src/data_frame.h 94.66% 1 Missing and 3 partials ⚠️
include/takane/string_factor.hpp 89.65% 0 Missing and 3 partials ⚠️
include/takane/_height.hpp 90.47% 2 Missing ⚠️
include/takane/_validate.hpp 90.90% 2 Missing ⚠️
include/takane/utils_hdf5.hpp 96.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   98.29%   97.33%   -0.96%     
==========================================
  Files          23       21       -2     
  Lines        2756     1426    -1330     
  Branches       57       22      -35     
==========================================
- Hits         2709     1388    -1321     
+ Misses         41       16      -25     
- Partials        6       22      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LTLA LTLA merged commit 6c66e7a into master Nov 19, 2023
3 of 5 checks passed
@LTLA LTLA deleted the simplified branch November 19, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant