Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full inventory troubles #7

Open
Quallysus opened this issue Aug 11, 2024 · 0 comments
Open

Full inventory troubles #7

Quallysus opened this issue Aug 11, 2024 · 0 comments

Comments

@Quallysus
Copy link

If a player picks up items, filling their inventory while in a trade, (assuming the player has items in the trade menu), on trade cancel, the items are entirely lost. Not dropped, just deleted.

Proposed solutions:

  • Disable item pickups while a player is currently in a trade
  • Drop items that are not able to be returned on trade cancels due to full inventories

How to reproduce:

  1. Start a trade between 2 accounts, where at least one account has something to put in the trade
  2. One account puts an item into the trade
  3. An external account drops items into the player's inventory, filling it
  4. The account without items in the trade cancels the trade, deleting the trade's items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant