Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

## PY29 - Moved to keep #30 clean #36

Closed
ArturoAmaya opened this issue Jun 15, 2022 · 5 comments
Closed

## PY29 - Moved to keep #30 clean #36

ArturoAmaya opened this issue Jun 15, 2022 · 5 comments

Comments

@ArturoAmaya
Copy link
Owner

PY29

Uploaded, generated

The prerequisites do be looking quite dense
image

Interestingly, the uploaded version lists math 20a as what seems to be a corequisite of math 18, while the generated version says math 20a is a prerequisite. The generated version isn't wrong because math 20a satisfies math 18's prerequisites. However, in practice, because we assume students have satisfied pre-calc, which is also an alternative prereq of math 18, students should be able to take 20a and 18 in the same quarter. This ultimately puts math 18 in a later column in the curriculum, but shouldn't affect degree plans I think. ⚠️

The uploaded version lists phys 4e as a prereq for phys 110a (in addition to math 20e), which makes it one column longer than the generated version. The generated version instead has phys 4d.

Interestingly, PHYS 4E isn't even a prereq for PHYS 110A:
image
so the uploaded version appears to be wrong.

Only the uploaded version lists math 20e as a prereq for phys 105a, but the generated version doesn't. I'm not sure why. I'll have to look into this. 🚩

Only the uploaded version lists math20e as a prereq for phys 100a. The generated version doesn't because math 20d already does

Only the generated version lists phys 4e as a prereq for phys 130a. I don't know why the uploaded version doesn't, but this might have to do with it listing phys 110a, another prereq of 130a, as requiring phys 4e.

Only the generated version lists math 20e as a prereq for phys 4d. This is correct.

Revelle

image

that's a lot of lines

For some reason, PHYS 2DL is in term 6 in the uploaded version but term 7 in the generated version.

More significantly, the updated version uses a corequisite arrow from math 20a to math 18 while the generated version uses a prerequisite arrow, despite the two courses being in the same quarter. Curricular Analytics renders this fine, but I think this should be changed: 🚩

  1. When editing the degree plan directly (by enabling editing mode, which I used to reorder the courses within quarters), math 18 pops ahead of 20a and can't be placed in the same quarter. This leads to somewhat buggy but not catastrophic behavior when you try to drag math 20a because it shows up to the left of the entire plan off the screen. Fortunately it snaps back to term 1 when you let go.
    image

  2. It probably also affects the complexity score (since it might think that math 20a blocks more courses than it actually should normally)

Since I don't think math 18 and 20a are listed as prereqs with concurrent enrollment enabled (I'd have to check this), to fix this, I could check if a prerequisite is in the same or later quarter and mark it as a corequisite instead

Originally posted by @SheepTester in #30 (comment)

@ArturoAmaya
Copy link
Owner Author

ArturoAmaya commented Jun 15, 2022

Only the uploaded version lists math 20e as a prereq for phys 105a, but the generated version doesn't. I'm not sure why. I'll have to look into this. 🚩

Hmmm, that's really strange. It shows up in the .csv, so maybe Curricular Analytics is doing something to it? Deep dive time (after I get lunch - edit I'm back now, found out why it happens - uploaded version has some missing prereq links, generated doesn't miss. writing up now).

@ArturoAmaya
Copy link
Owner Author

Only the uploaded version lists math 20e as a prereq for phys 105a, but the generated version doesn't. I'm not sure why. I'll have to look into this. 🚩

This happens because the generated version lists 4D as a pre-req of 105a when the uploaded version does not. Then, the generated version lists 20E as a pre-req for both 4D and 4E when the uploaded version does not. When the GUI is generated from the generated version, 20E folds into 4D and 4E pre-reqs and we get that only 4E is a direct pre-req of 105a. In the uploaded version, since 105a doesn't depend on 4D and neither 4D nor 4E depend on 20E but 105 depends on 20E, 20E is at the top of a pre-req chain for 105a and thus appears as a direct pre-req.

Per the catalog:
image
4D indeed depends on 20E, as does 4E.
image
105a does indeed depend on 4D.

That is, the generated version is correct. Interestingly, the generated version lists 4B as a requirement when only 4C-D-E are required.
image
This is inherited from the pre-reqs document. I will flag it.
image

@ArturoAmaya
Copy link
Owner Author

Only the generated version lists phys 4e as a prereq for phys 130a. I don't know why the uploaded version doesn't, but this might have to do with it listing phys 110a, another prereq of 130a, as requiring phys 4e.

Yeah, that's roughly it. The catalog explicitly lists 100A, 110A and 4E as pre-reqs for 130A. The .csv for the uploaded version lists all three, but it also lists 4E as a direct pre-req of 100A and 110A. The catalog disagrees - 4E is not a pre-req of 100A or 110A.

So, in the uploaded version 4E folds into being a direct pre-req of 100A and 110A, which are in turn direct pre-reqs of 130A. That is incorrect. The correct form is the generated form, where 4E is not a prereq of either, so it is a direct pre-req of 130A.

@ArturoAmaya
Copy link
Owner Author

For some reason, PHYS 2DL is in term 6 in the uploaded version but term 7 in the generated version.

Yeah, no idea but it matches with the online plan generator, so it's totally fine.

@SheepTester
Copy link
Collaborator

Seems like the generated version is correct so I'll close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants