Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degree plan course IDs need to match those in their curriculum #39

Closed
SheepTester opened this issue Jun 16, 2022 · 4 comments · Fixed by #41
Closed

Degree plan course IDs need to match those in their curriculum #39

SheepTester opened this issue Jun 16, 2022 · 4 comments · Fixed by #41
Assignees

Comments

@SheepTester
Copy link
Collaborator

SheepTester commented Jun 16, 2022

Discovered in #30

So apparently Curricular Analytics is very annoying, and for determining prerequisites of a course, it uses the course IDs from the curriculum.

We had I guess unwisely assumed that degree plans are completely independent, but they aren't. We've gone so long without noticing because major courses tend (with some exceptions) to be taken in the same order per major, so they get assigned the same course IDs. However, we can't rely on this

Fortunately, this is only relevant for prerequisites; courses that do not have prerequisites or are not prerequisites do not need to have a stable course ID. This is particularly relevant for some courses that can't be prerequisites because no meaningful course name can be parsed from them (eg "ELECTIVE")

I think the way I'll approach this is to get the curriculum (based on Marshall's academic plan) first, give IDs to each course (whose name can be parsed, i.e. a specific course subject + number rather than a generic "CSE elective"), and then use these IDs for degree plans.

Some investigation might be required to see if Curricular Analytics requires course IDs to be sorted, consecutive, etc. (i.e. whether I can just make them jump around), but I think I'll just assume it's nice and they just care they're unique and hope it's not more complicated than that

@SheepTester SheepTester self-assigned this Jun 16, 2022
@ArturoAmaya
Copy link
Owner

Sounds good boss. This morning I totally missed this and just sorted the courses alphabetically when they were parsed into degree plans (importantly, pre-curriculum) and it seems to have made most of the stuff go away, but I'm not quite sure. I commented on #30 if you want to check it out. Feel free to do either, and figuring out whether or not CA requires course IDs to be sorted is pretty interesting.

@SheepTester
Copy link
Collaborator Author

It seems CA doesn't really care if the IDs are sorted

Sorting the course names should help, but are there any degree plans where a major course is taken in a different quarter? Because I think that might still change its course ID

@ArturoAmaya
Copy link
Owner

Off the top of my head I can't remember, but I'll investigate that now.

@ArturoAmaya
Copy link
Owner

ArturoAmaya commented Jun 17, 2022

I'm taking this for a spin with MC25 and MC27 (the two most complicated majors I know). MC25 looks good for each college 👍 🥳 . Starting on MC27 - WA, RE, TH cleared. Looking great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants