Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curricular Analytics only draws one prereq #59

Open
SheepTester opened this issue Jun 24, 2022 · 14 comments
Open

Curricular Analytics only draws one prereq #59

SheepTester opened this issue Jun 24, 2022 · 14 comments

Comments

@SheepTester
Copy link
Collaborator

In IS28/Sixth,

visualization CSV
image CAT 1 is a prereq of only the second INTL 101 image Both courses list CAT 1 as a prereq

This seems to occur for other degree plans in the major

"INTL 101 or 102" gets parsed as INTL 101; both INTL 101 and 102 require at least one quarter of a writing sequence.

@SheepTester
Copy link
Collaborator Author

PS25/ERC has two MMW 14's

image

It's probably because there are two MMW 14/GE, so one of them should be MMW 14 and the other is GE, but since the code removes /GE from course titles, it looks like there are two MMW 14s

@SheepTester
Copy link
Collaborator Author

SE27, SE 131A has no prereqs

image

But it does!
image
image

The CSV doesn't recognize any of the courses as a prereq
image

That's because prereqs.csv doesn't have any prereqs for SE 131A
image

@SheepTester
Copy link
Collaborator Author

In US26, it mentions Sixth practicum

This is wacky because I thought we were using Marshall for curricula, and Marshall doesn't say Sixth practicum

curriculum marshall degree plan
image image

oh.

image

oops, I forgot to break out of this loop, so it was using the most weird college to base the curricula, Sixth, not Marshall. oh well!

@ArturoAmaya
Copy link
Owner

On the IS28 issue, the Julia package seems to point to exactly what you said. It did understand that they both have a pre-req relationship with HUM1 (in this case, I used the Revelle degree plan).
image
Do you think it's specifically because they have the same name?

@ArturoAmaya
Copy link
Owner

ArturoAmaya commented Jun 27, 2022

So, I made one with a third "INTL 101 or 102" and it correctly got the requirement of HUM 1. Weird.
image

Edit: I tried making that new third INTL 101 or 102 a prereq of INTL 190 like the first one is, and it couldn't draw the line for me. Interesting.
image
image

@SheepTester
Copy link
Collaborator Author

I wonder if it has to do with the parent curriculum affecting the prerequisites of the degree plans

@ArturoAmaya
Copy link
Owner

Don't the parent versions of the courses not have pre-reqs at all?

@ArturoAmaya
Copy link
Owner

ArturoAmaya commented Jun 27, 2022

The GUI had absolutely no problem letting me add the pre-req relationship. It gets weirder. I downloaded the file that worked from the GUI and it's identical to the one I uploaded. Uh actually, I dunno if it updates the csvs you can dowload lemme check that.

@SheepTester
Copy link
Collaborator Author

SheepTester commented Jun 27, 2022

I don't think it updates the original CSV file when you use the GUI

@ArturoAmaya
Copy link
Owner

Yeah it doesn't that was a dumb comparison. My b. Either way, it seems to understand adding in the pre-req in the GUI no problem.

@SheepTester
Copy link
Collaborator Author

I don't think this happens often enough so we could probably manually fix it when it happens with the GUI

@ArturoAmaya
Copy link
Owner

ArturoAmaya commented Jun 27, 2022

Sounds good to me.

@ArturoAmaya
Copy link
Owner

ArturoAmaya commented Jun 29, 2022

Out of curiosity, I tried it out in the Julia package... and it works fine. INTL101 or 102 1 correctly had CAT 1 as a pre-req. Admittedly, those degree plans exist abstractly; I don't recall how to link them to a curriculum to accurately reproduce our situation. Just a curious fact then I guess.

@SheepTester
Copy link
Collaborator Author

I forget if we've noted this but (Revelle BE25)
image
image
MAE 40 and MATH 18 are in the same quarter but the latter is a prereq of the former

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants