From 0e4d98049707d089a836ae5b06cf77b889cb2543 Mon Sep 17 00:00:00 2001
From: klingbolt <klingbeilrichard@gmail.com>
Date: Tue, 31 Oct 2023 00:13:46 -0400
Subject: [PATCH] Fixed a bug in bool.cpp and updated the test since there is
 no default return

---
 .../expected_outputs/xml_can_fade_invalid/xml_file.xml          | 2 +-
 xml_converter/src/attribute/bool.cpp                            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xml_converter/intigration_tests/expected_outputs/xml_can_fade_invalid/xml_file.xml b/xml_converter/intigration_tests/expected_outputs/xml_can_fade_invalid/xml_file.xml
index 98fc5d35..30e1dcdb 100644
--- a/xml_converter/intigration_tests/expected_outputs/xml_can_fade_invalid/xml_file.xml
+++ b/xml_converter/intigration_tests/expected_outputs/xml_can_fade_invalid/xml_file.xml
@@ -3,6 +3,6 @@
 </MarkerCategory>
 
 <POIs>
-<POI  CanFade="false" Type="mycategory" IconFile="texture.png" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002"/>
+<POI  Type="mycategory" IconFile="texture.png" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002"/>
 </POIs>
 </OverlayData>
diff --git a/xml_converter/src/attribute/bool.cpp b/xml_converter/src/attribute/bool.cpp
index 1e63b310..f011bb94 100644
--- a/xml_converter/src/attribute/bool.cpp
+++ b/xml_converter/src/attribute/bool.cpp
@@ -40,7 +40,7 @@ void xml_attribute_to_bool(
 // Converts a bool into a fully qualified xml attribute string.
 ////////////////////////////////////////////////////////////////////////////////
 string bool_to_xml_attribute(const string& attribute_name, const bool* value) {
-    if (value) {
+    if (*value) {
         return " " + attribute_name + "=\"true\"";
     }
     else {