Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle values above sintmax and uintmax #288

Open
AsherGlick opened this issue May 19, 2024 · 0 comments
Open

Gracefully handle values above sintmax and uintmax #288

AsherGlick opened this issue May 19, 2024 · 0 comments

Comments

@AsherGlick
Copy link
Owner

The following tests cause the xml converter to try to parse a value larger then a signed int32 max

<POI AchievementBit="2147483648" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" />
<POI AchievementBit="4294967295" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" />

The error is

terminate called after throwing an instance of 'std::out_of_range'

xml_converter should be able to gracefully handle this error as a linter error and not crash the entire program.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AsherGlick