Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blink-cmp): disable cmp-git #1268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

windowsrefund
Copy link
Contributor

Ensure cmp-git is no longer enabled.

Copy link

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft
Copy link
Member

Uzaaft commented Nov 18, 2024

@windowsrefund Do you have a reference or a link as to why this plugin needs to be disabled?

@windowsrefund
Copy link
Contributor Author

@Uzaaft
Copy link
Member

Uzaaft commented Nov 18, 2024

Doesnt answer the questiion. Why does it have to be disabled? doesnt it work with the plugin?

@windowsrefund
Copy link
Contributor Author

How would it work if cmp itself is disabled?

@Uzaaft
Copy link
Member

Uzaaft commented Nov 19, 2024

How would it work if cmp itself is disabled?

This one isn’t built in.

@Uzaaft
Copy link
Member

Uzaaft commented Nov 19, 2024

All the other plugins being disabled are built ins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants