Skip to content
This repository has been archived by the owner on Jan 17, 2020. It is now read-only.

Hitting unimplemented!() #149

Open
bestouff opened this issue May 17, 2019 · 6 comments
Open

Hitting unimplemented!() #149

bestouff opened this issue May 17, 2019 · 6 comments

Comments

@bestouff
Copy link

I'm hitting unimplemented!() in this function, in src/client/mqttstate.rs (line 71):

    pub fn handle_outgoing_mqtt_packet(&mut self, packet: Packet) -> Result<Request, NetworkError> {
        let out = match packet {
            Packet::Publish(publish) => {
                let publish = self.handle_outgoing_publish(publish)?;
                Request::Publish(publish)
            }
            Packet::Pingreq => self.handle_outgoing_ping()?,
            Packet::Subscribe(subs) => {
                let subscription = self.handle_outgoing_subscribe(subs)?;
                Request::Subscribe(subscription)                                                                        
            }
            _ => unimplemented!(),
        };

... right when unsubscribing/resubscribing a topic.

@tekjar
Copy link

tekjar commented May 22, 2019

As you've noted, unsubscribe isn't implemented yet. I'll take this up in June

@bestouff
Copy link
Author

That's OK, let this issue live as a tracker for this feature.

@rcastill
Copy link

Hi, is this feature planned for implementation any time soon?

@tekjar
Copy link

tekjar commented Dec 12, 2019

@rcastill Hi. I’m not working on this repo anymore. I’m not sure if there are any plans on features. Follow the progress of a different implementation in the below repo

https://github.com/tekjar/rumq

@rcastill
Copy link

Thanks for the info.

I’d recommend to update the README with a disclaimer pointing that out.

I’ll give the new repo a try!

@tekjar
Copy link

tekjar commented Dec 12, 2019

I’m not working at Ather anymore but somehow I still have admin permissions :) I don’t feel entitled to change readme though

The new repo is still in alpha and the feature might not be there as well. But the probability that I implement what you need is much higher there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants