Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing resolvable markets needs to be paginated, removed from market factory #1293

Closed
2 of 4 tasks
robert-e-davidson3 opened this issue Sep 23, 2021 · 0 comments · May be fixed by #1454
Closed
2 of 4 tasks

Listing resolvable markets needs to be paginated, removed from market factory #1293

robert-e-davidson3 opened this issue Sep 23, 2021 · 0 comments · May be fixed by #1454
Assignees
Labels
Milestone

Comments

@robert-e-davidson3
Copy link
Contributor

robert-e-davidson3 commented Sep 23, 2021

Reading from ethereum nodes doesn't take any gas but many ethereum nodes use a timeout low enough that listResolvableEvents and similar will fail as the number of markets increases. This is currently causing issues with the SportsLinkMarketFactory, at around 550 markets.

Also, there's no reason for this read-only method to be part of the market factory itself. Since market factory contract size is at a premium, it's better to expose the right read methods and move this code into the fetcher or a specialized contract.

Subtasks:

  • Solidity changes
  • Adapter does pagination.
  • Deploy changes
  • Tests
@robert-e-davidson3 robert-e-davidson3 self-assigned this Sep 23, 2021
@robert-e-davidson3 robert-e-davidson3 linked a pull request Oct 11, 2021 that will close this issue
@robert-e-davidson3 robert-e-davidson3 linked a pull request Oct 11, 2021 that will close this issue
@namankumar namankumar added this to the v1.5.1 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants