-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced accessibility features #18
Comments
For a lot of these accessibility features we'll need to make changes to aragon-ui components. Do we want to cover updating the aragon-ui comonents in this epic, or would we want to make our own versions of the components? |
I don't think we should maintain our own version of the aragonUI components. I think if it requires changing an actual aragonUI component, the deliverable for those use cases can involve cover clearly specifying the changes that need to be made to the components, so we can discuss it with Aragon One. |
@Quazia @stellarmagnet I've added some acceptance criteria to this epic to account for the above. Let me know if this makes sense. |
I like the updates @javieralaves! We need to add that non-aragonUI components should be updated. We may want to create another epic for actually updating the aragonUI components. |
@stellarmagnet Alternatively, could we fit it an 'Update aragonUI components' issue on to epic #22 'Maintaining Open Enterprise'? |
@javieralaves that would be something that comes after we code the updates to the aragonUI components and get them merged into the aragon/aragonUI repo. If we are having epics based on initiatives, both are related to making Aragon more inclusive. Regardless, the changes to Open enterprise may not be possible until January or February, if you take into account the review cycles for aragonSDK |
As far as this epic goes, shall we focus then first on non-aragonUI components (I've updated the acceptance criteria to reflect that), and then if there are any aragonUI components that need changing; let Radek document those for us so we can get Aragon One involved as soon as possible? PS: If any of our non-aragonUI components don't match accessibility standards, also let me know so we can work it out on Figma in parallel. |
Description
Addressing accessibility issues found by the react-axe audits on Open Enterprise apps.
Acceptance criteria
The text was updated successfully, but these errors were encountered: