Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced accessibility features #18

Open
6 tasks
javieralaves opened this issue Dec 2, 2019 · 7 comments
Open
6 tasks

Enhanced accessibility features #18

javieralaves opened this issue Dec 2, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request epic
Milestone

Comments

@javieralaves
Copy link
Contributor

javieralaves commented Dec 2, 2019

Description

Addressing accessibility issues found by the react-axe audits on Open Enterprise apps.

Acceptance criteria

  • Update non-aragonUI components with recognized issues identified by the audit
  • AragonUI components with recognized issues have been identified
  • Suggested changes per component have been documented and delivered to the Product team
  • Suggestions have been communicated and discussed with Aragon One
  • Suggestions have been requested on aragonUI for components to be updated
  • Components have been updated with improved accessibility standards
@javieralaves javieralaves added this to the Sprint B2 milestone Dec 2, 2019
@Quazia
Copy link

Quazia commented Dec 2, 2019

For a lot of these accessibility features we'll need to make changes to aragon-ui components. Do we want to cover updating the aragon-ui comonents in this epic, or would we want to make our own versions of the components?

@stellarmagnet
Copy link
Collaborator

I don't think we should maintain our own version of the aragonUI components. I think if it requires changing an actual aragonUI component, the deliverable for those use cases can involve cover clearly specifying the changes that need to be made to the components, so we can discuss it with Aragon One.

@javieralaves
Copy link
Contributor Author

@Quazia @stellarmagnet I've added some acceptance criteria to this epic to account for the above. Let me know if this makes sense.

@stellarmagnet
Copy link
Collaborator

stellarmagnet commented Dec 3, 2019

I like the updates @javieralaves! We need to add that non-aragonUI components should be updated. We may want to create another epic for actually updating the aragonUI components.

@javieralaves
Copy link
Contributor Author

@stellarmagnet Alternatively, could we fit it an 'Update aragonUI components' issue on to epic #22 'Maintaining Open Enterprise'?

@stellarmagnet
Copy link
Collaborator

stellarmagnet commented Dec 3, 2019

@javieralaves that would be something that comes after we code the updates to the aragonUI components and get them merged into the aragon/aragonUI repo. If we are having epics based on initiatives, both are related to making Aragon more inclusive.

Regardless, the changes to Open enterprise may not be possible until January or February, if you take into account the review cycles for aragonSDK

@javieralaves
Copy link
Contributor Author

As far as this epic goes, shall we focus then first on non-aragonUI components (I've updated the acceptance criteria to reflect that), and then if there are any aragonUI components that need changing; let Radek document those for us so we can get Aragon One involved as soon as possible?

PS: If any of our non-aragonUI components don't match accessibility standards, also let me know so we can work it out on Figma in parallel.

@stellarmagnet stellarmagnet modified the milestones: Sprint B2, Sprint B3 Dec 3, 2019
@javieralaves javieralaves removed this from the Sprint B3 milestone Dec 16, 2019
@javieralaves javieralaves added the enhancement New feature or request label Dec 20, 2019
@javieralaves javieralaves added this to the Sprint C1 milestone Dec 20, 2019
@javieralaves javieralaves modified the milestones: Sprint C1, Sprint B3 Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic
Projects
None yet
Development

No branches or pull requests

4 participants