Add a timeout argument to TCPClient #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuart-auterion
requested review from
ThomasDebrunner,
ruterion89 and
jacobbandyk
jacobbandyk
approved these changes
Jun 7, 2024
ThomasDebrunner
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially I'm re-making #29. Finally tracked down a reproducible cause for this. Refer to thread here. I'll be honest, I'm not an expert on Unix sockets, and don't entirely understand why, but something here is getting help open and blocking. Its clearly blocking something in the sockets layer because our application code that calls this is already in an independent thread and shouldn't care if that application thread itself is blocked.
Regardless, the timeout I added is an optional argument that shouldn't affect anything if it isn't used.