-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploy CMP control center on AWS using terraform #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As previously discussed, we still need to:
|
daniel-y
reviewed
Aug 7, 2024
…ic networks as a submodule
…olicy Role and Bucket (if absent) to the EC2 instance.
…not conflict; complete the optimization of the entire module.
…ictions on env names, etc. Complete the optimization points discussed in the meeting
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
modules/aws-cn/terraform.tfvars
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refer to the comment on variables.tf, update the description and variable name. @Kris20030907
cyifei2023
reviewed
Aug 10, 2024
cyifei2023
reviewed
Aug 10, 2024
Consider add two examples for using this module:
|
… for BYOC deployment of aws global.
Gezi-lzq
approved these changes
Aug 12, 2024
cyifei2023
reviewed
Aug 13, 2024
cyifei2023
reviewed
Aug 13, 2024
cyifei2023
reviewed
Aug 13, 2024
cyifei2023
reviewed
Aug 13, 2024
cyifei2023
reviewed
Aug 13, 2024
cyifei2023
reviewed
Aug 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the terraform construction of the entire set of cmp services (when vpc is provided)
Specific submission
README.md
: Configuration Guideaws-cn/main.tf
: Configure and start sub-modules to implement service constructionterraform.tfvars
: Service resource configurationoutputs
: Output deployment resource informationCan be optimized or to be considered