Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy CMP control center on AWS using terraform #6

Merged
merged 21 commits into from
Aug 13, 2024
Merged

Conversation

Kris20030907
Copy link
Contributor

@Kris20030907 Kris20030907 commented Aug 7, 2024

Complete the terraform construction of the entire set of cmp services (when vpc is provided)

Specific submission

  1. README.md: Configuration Guide
  2. aws-cn/main.tf: Configure and start sub-modules to implement service construction
  3. terraform.tfvars: Service resource configuration
  4. outputs: Output deployment resource information

Can be optimized or to be considered

  1. The deployment is now completed with the VPC and public subnet provided. This can be achieved through submodules.
  2. Security group port opening issue: When the data plane and control plane share a common security group, the user-side customizes the CIDR. To be discussed

@Kris20030907 Kris20030907 requested a review from daniel-y August 7, 2024 06:45
@daniel-y daniel-y marked this pull request as draft August 7, 2024 11:48
@daniel-y
Copy link
Contributor

daniel-y commented Aug 7, 2024

As previously discussed, we still need to:

  • Set up the ops bucket and data bucket configurations.
  • Obtain the necessary permissions for the CMP through an IAM role.
  • Grant our account access to the ops bucket.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to the comment on variables.tf, update the description and variable name. @Kris20030907

@daniel-y
Copy link
Contributor

Consider add two examples for using this module:

  1. Use existed VPC, data bucket, as well as ops bucket.
  2. Create all related resources for deploying automq byoc environment.

@Gezi-lzq Gezi-lzq marked this pull request as ready for review August 13, 2024 02:22
@Gezi-lzq Gezi-lzq merged commit 00abb43 into main Aug 13, 2024
14 checks passed
@Kris20030907 Kris20030907 deleted the zhaoxi-tf-cmp branch August 13, 2024 02:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants