Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log files don't have all logs from terminal! #673

Closed
vjeeva opened this issue Feb 3, 2025 · 1 comment
Closed

Log files don't have all logs from terminal! #673

vjeeva opened this issue Feb 3, 2025 · 1 comment

Comments

@vjeeva
Copy link
Contributor

vjeeva commented Feb 3, 2025

Problem:

  • People run multiple commands
  • Sometimes people rerun commands
  • Previous logs get overwritten on disk

Definition of Done

  • Log files need to be APPENDED in all functions.
  • Clearly some functions are not logging to disk but only to terminal... WHY?
vjeeva added a commit that referenced this issue Feb 3, 2025
@vjeeva
fix: loggers were overwriting themselves on disk. Separated now #673
c4b798e
vjeeva added a commit that referenced this issue Feb 3, 2025
@vjeeva
fix: loggers were overwriting themselves on disk. Separated now #673 (#…
f39c73d 
…674)
@vjeeva vjeeva mentioned this issue Feb 3, 2025
Merged
@vjeeva
Copy link
Contributor Author

vjeeva commented Feb 24, 2025

Turns out the issue was that commands in pgbelt were reusing the same logger, so some processes would overload the same logger instance and we would lose logs.

Separated the loggers out in #674 and that solved it. Closed!

@vjeeva vjeeva closed this as completed Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vjeeva