-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting up of _s_posted_on should be reverted #1256
Comments
I proposed the original idea. I believe we can address both. But Posted On is a Date function and Posted By is an Authorship function. They should be separate in that regard. Can you propose a solution that addresses both? |
Sorry, busy with other things at the moment. I'll leave finding a solution for this up to others for now. |
Understood. |
From a l10n pov, I think that the current version is slightly better than what we had before, but both are actually quite bad. The best solution would simply be a single string that includes both parts: |
I experimented with this, but using a simplified string creates a new issue; the lack of wrappers around the post date and author, allowing us to style these pieces and their surrounding text with CSS. Should we consider remove the surrounding text altogether? Displaying just the date/time and author separately with a separator, like:
If not, it seems like the current solution is a slight improvement, in any case, and should stay. |
Agree with @sixhours here on both of her points. |
We can still do this with one function. See #1282 for an untested POC. |
I think we need to think outside the box and try something new. Here are a few screenshots from a few blogs. I am not very keen on adding HTML to the translations strings as suggested in #1282. |
See #1213 and #1226.
From: #1213 (comment)
The text was updated successfully, but these errors were encountered: