Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting up of _s_posted_on should be reverted #1256

Open
jrfnl opened this issue Jan 29, 2018 · 9 comments
Open

Splitting up of _s_posted_on should be reverted #1256

jrfnl opened this issue Jan 29, 2018 · 9 comments

Comments

@jrfnl
Copy link
Contributor

jrfnl commented Jan 29, 2018

See #1213 and #1226.

From: #1213 (comment)

The current split as has been merged is a deterioration from a localization point of view as the sentence structure is now broken up in two methods and two individually translatable phrases which together form a sentence with the sentence order presuming English / left-to-right sentence structure.

@dshanske
Copy link

I proposed the original idea. I believe we can address both. But Posted On is a Date function and Posted By is an Authorship function. They should be separate in that regard.

Can you propose a solution that addresses both?

@jrfnl
Copy link
Contributor Author

jrfnl commented Jan 29, 2018

Sorry, busy with other things at the moment. I'll leave finding a solution for this up to others for now.

@dshanske
Copy link

Understood.

@laurelfulford
Copy link
Contributor

Thanks for creating this issue, @jrfnl!

@yoavf I'd appreciate your expertise here, for ways to improve localization of the post title and byline, if there's something we can do in its current form (split into two functions) or if it's best to revert. Thank you!

@yoavf
Copy link
Contributor

yoavf commented Mar 6, 2018

From a l10n pov, I think that the current version is slightly better than what we had before, but both are actually quite bad.

The best solution would simply be a single string that includes both parts:
Something like __( 'Posted on %1$s by %2$s' ) with %1$s and %1$2 being the localized date and the user link, respectively.

@sixhours
Copy link
Contributor

sixhours commented Mar 8, 2018

The best solution would simply be a single string that includes both parts:
Something like __( 'Posted on %1$s by %2$s' ) with %1$s and %1$2 being the localized date and the user link, respectively.

I experimented with this, but using a simplified string creates a new issue; the lack of wrappers around the post date and author, allowing us to style these pieces and their surrounding text with CSS.

Should we consider remove the surrounding text altogether? Displaying just the date/time and author separately with a separator, like:

March 3, 2018 | Author Name

If not, it seems like the current solution is a slight improvement, in any case, and should stay.

@philiparthurmoore
Copy link
Collaborator

Agree with @sixhours here on both of her points.

@yoavf
Copy link
Contributor

yoavf commented Apr 8, 2018

I experimented with this, but using a simplified string creates a new issue; the lack of wrappers around the post date and author, allowing us to style these pieces and their surrounding text with CSS.

We can still do this with one function. See #1282 for an untested POC.

@grappler
Copy link
Collaborator

I think we need to think outside the box and try something new. Here are a few screenshots from a few blogs.

image
image
image

I am not very keen on adding HTML to the translations strings as suggested in #1282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants