Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Configure diagnostic severity per linter #306

Open
ficcdaf opened this issue Dec 6, 2024 · 3 comments · May be fixed by #312
Open

Feat: Configure diagnostic severity per linter #306

ficcdaf opened this issue Dec 6, 2024 · 3 comments · May be fixed by #312
Labels
enhancement New feature or request harper-ls

Comments

@ficcdaf
Copy link
Contributor

ficcdaf commented Dec 6, 2024 •
edited
Loading

Currently, the diagnosticSeverity configuration option applies globally to all of Harper's output. However, it would be nice to have an option to configure a different severity for each linter. For example, I would like to set spell_check and sentence_capitalization to the error severity, while some other things like spaces and linking_verbs would make more sense as warning or info. For reference, ltex-ls implements this feature.
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 11, 2024
@grantlemons
feat(Automattic#306): configurable lint severity by linter
08b6490
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 11, 2024
@grantlemons
feat(Automattic#306): harper-ls supporting default and specific lint …
c42aecd 
…severities
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 12, 2024
@grantlemons
fix(Automattic#306): satisfy clippy
121c138
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 12, 2024
@grantlemons
feat(Automattic#306): configurable lint severity by linter
eaf7a9f
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 12, 2024
@grantlemons
feat(Automattic#306): harper-ls supporting default and specific lint …
c7c4ccc 
…severities
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 12, 2024
@grantlemons
fix(Automattic#306): satisfy clippy
cddf425
@elijah-potter elijah-potter linked a pull request Dec 30, 2024 that will close this issue
feat(#306): individual linter diagnostic severities #312
Draft
@elijah-potter
Copy link
Collaborator

elijah-potter commented Dec 30, 2024 •
edited
Loading

Hey @ficcdaf,

I like this idea. I don't imagine this would be difficult to implement. It is somewhat lower priority, so it might be a bit before I can get to it. It looks like @grantlemons has taken it up. He might be able to provide a status on it.

Thanks for raising the issue!

@grantlemons
Copy link
Collaborator

Status was that it was supported by harper-ls, but still needed integration with harper-wasm, and the vscode plugin.

I'll need to revisit it to ensure nothing was broken by all the changes to master recently.

@ficcdaf
Copy link
Contributor Author

ficcdaf commented Dec 31, 2024

No problem and no rush. Thanks for all your hard work!

@grantlemons grantlemons added the enhancement New feature or request label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request harper-ls
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#306): individual linter diagnostic severities grantlemons/harper
3 participants
@grantlemons @ficcdaf @elijah-potter