Skip to content
This repository has been archived by the owner on Feb 22, 2019. It is now read-only.

Drop Moment and Moment Timezone #61

Open
blowery opened this issue Jun 15, 2018 · 2 comments
Open

Drop Moment and Moment Timezone #61

blowery opened this issue Jun 15, 2018 · 2 comments

Comments

@blowery
Copy link
Contributor

blowery commented Jun 15, 2018

We're not supplying any custom translations for these and having them as dependencies forces them on clients of this module. Both are quite large when bundled with webpack and would be better included by a client project if they wish to use them.

@beaucollins
Copy link

At the very least relax the version requirement. We're using i18n-calypso in a project that also uses moment-timezone and now we have two moment-timezones:

pasted_image_8_24_18__9_40_am

moment-timezone@^0.5 seems reasonable.

@beaucollins
Copy link

I see #65 already deletes the dependency now!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants