Skip to content
This repository has been archived by the owner on Feb 22, 2019. It is now read-only.

Bump interpolate-components to 1.1.1 (for React 16 compat) #45

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Nov 9, 2017

Also bump version, Changelog

See Automattic/interpolate-components#12.

To Test

@ockham ockham force-pushed the update/interpolate-components branch from 5ccbe80 to d7c748b Compare November 16, 2017 18:37
@ockham ockham changed the title Bump interpolate-components to v1.1.1 Bump interpolate-components to 1.1.1 (for React 16 compat) Nov 16, 2017
@ockham
Copy link
Contributor Author

ockham commented Nov 16, 2017

Ready for review!

@samouri
Copy link
Contributor

samouri commented Nov 16, 2017

@ockham: do we need to do anything other than ensure unit tests pass?

@ockham
Copy link
Contributor Author

ockham commented Nov 18, 2017

I just (pre-)released this as 1.8.4-alpha.4 and updated Automattic/wp-calypso#19658, so let's use that PR to test if it works fine with Calypso.

@samouri
Copy link
Contributor

samouri commented Nov 21, 2017

i checked update/i18n-calypso in wp-calypso, cleared node_modules and reinstalled, and translations actually worked better than ever.

This branch makes clicking update settings work on the first try, whereas on master it takes a second refresh.

💯 🎉 .

@ockham ockham merged commit b8899ef into master Nov 21, 2017
@ockham ockham deleted the update/interpolate-components branch November 21, 2017 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants