Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

Be more informative if launching a Jetpack branch fails due to the branch not being part of a Pull Request #140

Open
oskosk opened this issue Oct 11, 2018 · 3 comments
Labels

Comments

@oskosk
Copy link
Collaborator

oskosk commented Oct 11, 2018

We only allow branches on Pull Requests to be used on the Jetpack Beta Tester Plugin (which is the basis for Jurassic Ninja's branch feature when asking for a site with Jetpack Beta Tester plugin jetpack-beta)

@oskosk oskosk added the bug label Oct 11, 2018
@sirreal
Copy link
Member

sirreal commented Oct 11, 2018

It would be nice to error if one of the requested branches can't be found, whether Calypso or Jetpack, rather than sliently booting with master.

@simison
Copy link
Member

simison commented Oct 23, 2018

Alternative "fix": show the current Jetpack+Calypso branch at the wp-admin bar.

@oskosk
Copy link
Collaborator Author

oskosk commented Oct 27, 2018

It would be nice to error if one of the requested branches can't be found, whether Calypso or Jetpack, rather than sliently booting with master.

This, I think, happened only when the gutenpack feature was first launched. A few bugs came up as it was a dirty hack. JN won't silently launch with master of any of the repos if the requested branches are not there.

The intention of this issue was mostly about tracking the need for informing whether a branch is not a PR because currently JN just shows a message stating that the branch probably hasn't been built yet instead of just asserting "It's not a PR".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants