Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GlobalStep] Sorting the list by "Payout Currency" option displays "No data to display" message on "Payments > Transactions" page. #10038

Closed
1 of 3 tasks
gglobalstep opened this issue Dec 24, 2024 · 2 comments · Fixed by #10041
Assignees
Labels
focus: payouts priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.

Comments

@gglobalstep
Copy link

gglobalstep commented Dec 24, 2024

Bug Description:

Sorting the list by "Payout Currency" option displays "No data to display" message on "Payments > Transactions" page.

Environment:

Woocommerce Version: WooCommerce 9.6.0-beta.1
WooCommerce Payments: 8.7.0-test-3
WordPress version: v6.7.1

PC:
Windows 10,
Chrome(Version 131.0.6778.140)
Firefox (Version133.0.3)

Steps To Reproduce:

  1. Create any test site.
  2. Install and activate all the required plugins.
  3. Install and activate the Woocommerce version 9.6.0-beta.1 plugin.
  4. Install the version of WooCommerce Payments 8.7.0-test-3 plugin.
  5. Complete WooCommerce Payments KYC flow.
  6. Add some sample products.
  7. Add an item to your cart, and go to checkout.
  8. Complete checkout by placing order.
  9. Create some more orders.
  10. As a Merchant, navigate to 'Payments -> Transactions'.
  11. Ensure the totals rendered at the transactions list bottom reflecting the correct amount of transactions.
  12. Ensure that sorting the list by 'Date/Time', 'Amount', 'Fees', 'Net' is not changing the totals and sorts list entries as expected.
  13. Click ellipses button on right side.
  14. Enable "Payout Currency" option by clicking toggle button.
  15. Now try to sort "Payout Currency" option.
  16. Observe that, Sorting the list by "Payout Currency" option displays "No data to display" message.

Instruction Link:

https://github.com/Automattic/woocommerce-payments/wiki/Testing-instructions-for-critical-flows#view-transactions

Actual Result:

Sorting the list by "Payout Currency" option displays "No data to display" message on "Payments > Transactions" page.

Expected Result:

Sorting the list by "Payout Currency" option should sort list entries as expected on "Payments > Transactions" page.

Video:

10038.mp4

Woocommerce bugs uploading format:

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.
System Status Report
### WordPress Environment ###

WordPress address (URL): [Redacted]
Site address (URL): [Redacted]
WC Version: 9.6.0-beta.1
Legacy REST API Package Version: The Legacy REST API plugin is not installed on this site.
Action Scheduler Version: ✔ 3.9.0
Log Directory Writable: ✔
WP Version: 6.7.1
WP Multisite: –
WP Memory Limit: 512 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
External object cache: ✔

### Server Environment ###

Server Info: nginx
PHP Version: 8.3.15
PHP Post Max Size: 2 GB
PHP Time Limit: 850
PHP Max Input Vars: 6144
cURL Version: 8.10.1
OpenSSL/3.0.15

SUHOSIN Installed: –
MySQL Version: 10.11.10-MariaDB-log
Max Upload Size: 2 GB
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
GZip: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

### Database ###

[REDACTED]

### Post Type Counts ###

attachment: 25
page: 9
post: 3
product: 24
product_variation: 7
revision: 4
shop_coupon: 1
shop_order_placehold: 143
wp_font_face: 36
wp_font_family: 12

### Security ###

Secure connection (HTTPS): ✔
Hide errors from visitors: ✔

### Active Plugins (6) ###

Akismet Anti-spam: Spam Protection: by Automattic - Anti-spam Team – 5.3.5
Code Snippets: by Code Snippets Pro – 3.6.6.1
Query Monitor: by John Blackbourn – 3.17.0
WooPayments: by WooCommerce – 8.7.0-test-3
WooCommerce Subscriptions: by WooCommerce – 7.0.0
WooCommerce: by Automattic – 9.6.0-beta.1

### Inactive Plugins (1) ###

WooCommerce Payments Dev Tools: by Automattic –

### Dropin Plugins () ###

advanced-cache.php: advanced-cache.php
db.php: Query Monitor Database Class (Drop-in)
object-cache.php: Memcached

### Must Use Plugins (1) ###

load.php: by  –

### Settings ###

Legacy API Enabled: –
Force SSL: –
Currency: USD ($)
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Number of Decimals: 2
Taxonomies: Product Types: external (external)
grouped (grouped)
simple (simple)
subscription (subscription)
variable (variable)
variable subscription (variable-subscription)

Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog)
exclude-from-search (exclude-from-search)
featured (featured)
outofstock (outofstock)
rated-1 (rated-1)
rated-2 (rated-2)
rated-3 (rated-3)
rated-4 (rated-4)
rated-5 (rated-5)

Connected to WooCommerce.com: –
Enforce Approved Product Download Directories: ✔
HPOS feature enabled: ✔
Order datastore: Automattic\WooCommerce\Internal\DataStores\Orders\OrdersTableDataStore
HPOS data sync enabled: –

### Logging ###

Enabled: ✔
Handler: Automattic\WooCommerce\Internal\Admin\Logging\LogHandlerFileV2
Retention period: 30 days
Level threshold: –
Log directory size: 9 MB

### WC Pages ###

Shop base: #7 - /shop/
Cart: #8 - /cart/ -  Contains the woocommerce/cart block
Checkout: #9 - /checkout/ -  Contains the woocommerce/checkout block
My account: #10 - /my-account/
Terms and conditions: ❌ Page not set

### Theme ###

Name: Storefront
Version: 4.6.0
Author URL: https://woocommerce.com/
Child Theme: ❌ – If you are modifying WooCommerce on a parent theme that you did not build personally we recommend using a child theme. See: How to create a child theme
Theme type: Classic theme
WooCommerce Support: ✔

### Templates ###

Overrides: –

### WooPayments ###

Version: 8.7.0-test-3
Connected to WPCOM: Yes
WPCOM Blog ID: 240150124
Account ID: acct_1QZRkgCOH4xNKsQd
Payment Gateway: Enabled
Test Mode: Enabled
Enabled APMs: card
WooPay: Disabled
WooPay Incompatible Extensions: No
Apple Pay / Google Pay: Enabled (product,cart,checkout)
Fraud Protection Level: basic
Multi-currency: Enabled
Auth and Capture: Disabled
Documents: Disabled
Logging: Enabled

### Subscriptions ###

WCS_DEBUG: ✔ No
Subscriptions Mode: ✔ Live
Subscriptions Live URL: https://remaining-caterpillar.jurassic.ninja
Subscriptions-core Library Version: 7.8.0
Subscription Statuses: wc-active: 27
wc-cancelled: 1

WooCommerce Account Connected: ❌ No
Report Cache Enabled: ✔ Yes
Cache Update Failures: ✔ 0 failure

### Store Setup ###

Country / State: United States (US) — California

### Subscriptions by Payment Gateway ###

WooPayments: wc-active: 27
wc-cancelled: 1


### Payment Gateway Support ###

WooPayments: products
refunds
multiple_subscriptions
subscription_cancellation
subscription_payment_method_change_admin
subscription_payment_method_change_customer
subscription_payment_method_change
subscription_reactivation
subscription_suspension
subscriptions
subscription_amount_changes
subscription_date_changes
tokenization
add_payment_method


### Admin ###

Enabled Features: activity-panels
analytics
product-block-editor
coupons
core-profiler
customize-store
customer-effort-score-tracks
import-products-task
experimental-fashion-sample-products
shipping-smart-defaults
shipping-setting-tour
homescreen
marketing
mobile-app-banner
onboarding
onboarding-tasks
pattern-toolkit-full-composability
product-custom-fields
remote-inbox-notifications
remote-free-extensions
payment-gateway-suggestions
printful
shipping-label-banner
subscriptions
store-alerts
transient-notices
woo-mobile-welcome
wc-pay-promotion
wc-pay-welcome-page
launch-your-store

Disabled Features: product-data-views
experimental-blocks
coming-soon-newsletter-template
minified-js
product-pre-publish-modal
settings
async-product-editor-category-field
product-editor-template-system
blueprint
reactify-classic-payments-settings
use-wp-horizon
add-to-cart-with-options-stepper-layout
blockified-add-to-cart

Daily Cron: ✔ Next scheduled: 2024-12-25 06:34:51 +00:00
Options: ✔
Notes: 61
Onboarding: skipped

### Action Scheduler ###

Canceled: 51
Oldest: 2024-12-24 07:17:58 +0000
Newest: 2024-12-24 13:22:56 +0000

Complete: 869
Oldest: 2024-12-24 06:36:15 +0000
Newest: 2024-12-24 09:59:11 +0000

Failed: 4
Oldest: 2024-12-24 06:51:25 +0000
Newest: 2024-12-24 09:39:26 +0000

Pending: 29
Oldest: 2024-12-25 06:36:15 +0000
Newest: 2025-02-24 10:00:00 +0000


### Status report information ###

Generated at: 2024-12-24 13:58:52 +00:00
@gglobalstep gglobalstep added the type: bug The issue is a confirmed bug. label Dec 24, 2024
@nagpai nagpai added priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability and removed priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. labels Dec 25, 2024
@nagpai
Copy link
Contributor

nagpai commented Dec 25, 2024

Adding a medium priority for now, since the bug is evident only after currency column is selected and sorted. I have added it to the Next queue so that we pick it up early.

@nagpai nagpai self-assigned this Dec 25, 2024
@nagpai
Copy link
Contributor

nagpai commented Dec 25, 2024

First glance: I ran a test on my local setup and found this error on server logstash

error: 'WCPay\Core\Data_Transfer_Objects\Transactions_List_Query::sort_field' should be one of 'wcpay_transactions_cache_id, stripe_account_id, transaction_id, type, date, source, source_identifier, customer_name, customer_email, customer_country, amount, fees, net, currency, amount_in_usd, risk_level, charge_id, exchange_rate, customer_amount, customer_currency, deposit_id, available_on, order_id' but 'deposit_currency' given

This indicates we are sending an unaccepted param - deposit_currency . The correct param / key for Payout currency would be just currency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: payouts priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants