Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QIT] Warning in class-wc-rest-user-exists-controller.php #6599

Open
ricardo opened this issue Jun 27, 2023 · 4 comments
Open

[QIT] Warning in class-wc-rest-user-exists-controller.php #6599

ricardo opened this issue Jun 27, 2023 · 4 comments
Labels
component: WooPay WooPay related issues focus: woopay size: small The issue is sized small. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@ricardo
Copy link
Member

ricardo commented Jun 27, 2023

Context: p1687217595824019/1687217105.664229-slack-CGGCLBN58

Message

register_rest_route() with permission_callback => __return_true

Source

audit.php.wp.security.rest-route.permission-callback.return-true

File

includes/admin/class-wc-rest-user-exists-controller.php:36

cc @malithsen

@ricardo ricardo added type: task The issue is an internally driven task (e.g. from another A8c team). size: small The issue is sized small. labels Jun 27, 2023
@zmaglica
Copy link
Contributor

zmaglica commented Jul 7, 2023

This issue impacts QIT, so assigning to Harmony (based on team responsibilities) @deepakpathania . Assigning as part of Gamma Triage process PcreKM-yM-p2.

@deepakpathania
Copy link
Contributor

Errors surfaced by the QIT report should go to relevant teams who own that part of the codebase. @zmaglica

@malithsen
Copy link
Member

Sorry, I missed the initial ping. To add some context, the endpoint defined in the file was initially removed in #6174. However, class-wc-rest-user-exists-controller.php file was brought back in #6303 to resolve an error that happens during the plugin upgrade. This file only exists to get around the upgrade error, and the API endpoint in the file is not registered or available anymore.

We have #6304 to address the root issue, after which class-wc-rest-user-exists-controller.php could be removed.

@haszari haszari added the focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). label Mar 11, 2024
@vbelolapotkov vbelolapotkov added component: WooPay WooPay related issues focus: woopay and removed focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). labels Mar 19, 2024
@vbelolapotkov
Copy link
Collaborator

To add some context, the endpoint defined in the file was initially removed in #6174

Based on this routing this issue to you @c-shultz for further prioritization. FWIW, I think it's blocked by #7464 #7465 and probably by #7147 , so adding blocked label as well.

@vbelolapotkov vbelolapotkov added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: WooPay WooPay related issues focus: woopay size: small The issue is sized small. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

No branches or pull requests

6 participants