Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRB/ECE refactor to utilize tokenized carts #8525

Open
7 of 10 tasks
frosso opened this issue Mar 29, 2024 · 1 comment
Open
7 of 10 tasks

PRB/ECE refactor to utilize tokenized carts #8525

frosso opened this issue Mar 29, 2024 · 1 comment
Labels
category: refactor The issue/PR is related to refactoring. Epic focus: checkout payments

Comments

@frosso
Copy link
Contributor

frosso commented Mar 29, 2024

Created as part of #8298 , following the investigation outlined on pbIwZe-1Mr-p2

  1. Integrate the new API on PDPs
    • To ensure seamless functionality and compatibility
  2. Integrate the new API on block-based cart & checkout pages
    • To make the integration “easier”, since they are both using the Store API
  3. Integrate the new API on shortcode cart & checkout pages
  4. Cleanup of the old implementation
    • This includes JS-related code, but also (now) unused custom endpoints

The multi-step approach could be executed in two ways:

  • Implementing the new functionality on the existing JS files (like I did in my POC)
    • This approach involves integrating the new functionality directly into the current JavaScript files, aligning with the existing code structure
  • Implementing the new functionality on new JS files
    • Creating separate JavaScript files dedicated to the new functionality

Although the second approach may initially introduce a slight uptick in complexity, I believe it offers distinct advantages.
It can pave the way for a smoother cleanup phase, enabling clearer isolation between the old and new implementations. This separation enhances code clarity and lays the groundwork for envisioning a future where solutions between WC Stripe and WooPayments can be seamlessly shared.

External dependencies

Preview Give feedback
  1. focus: store api priority: normal team: Rubik type: bug
  2. focus: checkout focus: store api needs: discussion priority: normal team: Rubik type: enhancement

Third-party extensions

Preview Give feedback

Issues that will be fixed once launched

Preview Give feedback
  1. category: core focus: checkout payments priority: medium status: blocked type: bug
  2. Component: International Expansion focus: checkout payments priority: medium status: blocked type: bug
  3. focus: payments acceptance & processing priority: low type: enhancement
  4. category: projects focus: checkout payments priority: high status: blocked type: bug
@frosso
Copy link
Contributor Author

frosso commented Aug 1, 2024

Since it's not linked here, the completeness of this project is also dependent on woocommerce/woocommerce#48540

EDIT: related to the above - I noticed another difference compared to the old flow: pay-for-order orders without a shipping address fail to process when using the Store API.
https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/src/StoreApi/docs/checkout-order.md#process-order-and-payment

EDIT 2: turns out that the shipping address discrepancy has more steps related to it - it also requires physical products on the main customer's cart.

@frosso frosso changed the title PRB refactor to utilize tokenized carts PRB/ECE refactor to utilize tokenized carts Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: refactor The issue/PR is related to refactoring. Epic focus: checkout payments
Projects
None yet
Development

No branches or pull requests

1 participant