Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECE] Finalize button presentation and design #9066

Closed
4 tasks done
Tracked by #8768
reykjalin opened this issue Jul 8, 2024 · 3 comments
Closed
4 tasks done
Tracked by #8768

[ECE] Finalize button presentation and design #9066

reykjalin opened this issue Jul 8, 2024 · 3 comments
Labels
component: payment request button Apple Pay, Google Pay, etc focus: checkout payments impact: high This issue impacts a lot of users as reported by our Happiness Engineers. needs design The issue requires design input/work from a designer. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: enhancement The issue is a request for an enhancement.

Comments

@reykjalin
Copy link
Contributor

reykjalin commented Jul 8, 2024

Description

There are still several issues with the ECE (Stripe's Express Checkout Element) presentation that we need to work through:

Tasks

Preview Give feedback
  1. category: core component: WooPay focus: woopay needs design priority: medium type: enhancement
    lovo-h

Acceptance criteria

  • ECE buttons render at least as well as PRB in terms of spacing, design, sizes, responsive breakpoints, etc.
  • The tasks listed in the PR description have been completed and/or fixed.

Designs

Testing instructions

See relevant issues and discussions.

Dev notes

Additional context

@reykjalin reykjalin added type: enhancement The issue is a request for an enhancement. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. needs design The issue requires design input/work from a designer. impact: high This issue impacts a lot of users as reported by our Happiness Engineers. component: payment request button Apple Pay, Google Pay, etc labels Jul 8, 2024
@pierorocca
Copy link
Contributor

Hey team could we also add this issue @rafaelzaleski has picked up to this list? #8136

It would look good on the team in the feature announcement and showcase if this new implementation avoids this very noticeable font size mismatch.

@haszari
Copy link
Contributor

haszari commented Jul 9, 2024

What's ECE? Recommend defining the acronym somewhere on these issues for newbies like me :)

AHA! Express Checkout Element #8768

@bborman22
Copy link
Contributor

Closing the epic for ECE design issues that were discovered. Thanks for the great work everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: payment request button Apple Pay, Google Pay, etc focus: checkout payments impact: high This issue impacts a lot of users as reported by our Happiness Engineers. needs design The issue requires design input/work from a designer. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants