-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add pre-commit #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
isamu-takagi
commented
Jun 18, 2024
- pre-commit を適用
- pre-commit CI を追加
- PRテンプレートの簡略化
isamu-takagi
pushed a commit
that referenced
this pull request
Jun 18, 2024
isamu-takagi
added a commit
that referenced
this pull request
Jun 18, 2024
* docs: add rosdep install command (#29) * docs: to accomodate the PR#30 in autoware-practice, update the command to run the node that publishes Trajectory (#27) * docs: modify node diagram around the trajectory_follower node (#30) * docs: add chapter1 docs (#28) * docs: to use Humble, modify the rosdep command (#31) * docs: add 2-4 (#23) * docs: add 3-1 (#34) Signed-off-by: Masahiro Kubota <[email protected]> --------- Signed-off-by: Masahiro Kubota <[email protected]> Co-authored-by: Masahiro Kubota <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
isamu-takagi
force-pushed
the
ci/pre-commit
branch
from
June 18, 2024 08:32
2bb4923
to
650d01b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一部表示崩れてしまっているのでコメントしました。
Signed-off-by: Takagi, Isamu <[email protected]>
masahiro-kubota
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!
knorrrr
pushed a commit
to knorrrr/aichallenge-documentation-2024
that referenced
this pull request
Jul 3, 2024
* docs: add rosdep install command (AutomotiveAIChallenge#29) * docs: to accomodate the PR#30 in autoware-practice, update the command to run the node that publishes Trajectory (AutomotiveAIChallenge#27) * docs: modify node diagram around the trajectory_follower node (AutomotiveAIChallenge#30) * docs: add chapter1 docs (AutomotiveAIChallenge#28) * docs: to use Humble, modify the rosdep command (AutomotiveAIChallenge#31) * docs: add 2-4 (AutomotiveAIChallenge#23) --------- Co-authored-by: Masahiro Kubota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.