Relocate shaded libraries to solve third party conflicts

[lokka30]

Linked to A248/LibertyBans#164.

This is no easy feat haha.

[A248]

Please file this as a bug, not a feature request.

Also, I'd like to say the solution is not quite difficult. At the minimum, a new major version will be required, but a version increment does not translate to difficulty of implementation. Relocating shaded dependencies, even within a library such as eco, is entirely possible.

[WillFP]

It's extremely easy, I do it already with Caffeine and many other libs that are used purely internally with eco. It's about compatibility

[A248]

It's extremely easy, I do it already with Caffeine and many other libs that are used purely internally with eco. It's about compatibility

I think you might have forgotten to implement this. Opening up the Eco plugin jar, I find the following shaded libraries:

• Caffeine
• MySQL driver
• Kyori Adventure and Examination
• org.jetbrains.exposed
• Kotlin, of course, which you have mentioned previously as bearing on compatibility

No relocation is applied to this libraries. The build file confirms this:

eco/build.gradle.kts

Line 163 in d826a9f

Kotlin and caffeine are not shaded so that they can be accessed directly by eco plugins.

It's no longer a problem in LibertyBans (whatsoever), however I thought you might find this information useful.

[masmc05]

this really should be fixed in a way, maybe a special relocation prefix only to kotlin and use that prefix on all eco plugins, as we have lots of issues with different plugins because of such behavior, of course we solve them, but it's not a very pleasant experience

This is a big minus that stops us from buying other eco depending plugin and makes us think of removing Talismans to lower such issues in future