Win32: fix position being changed on Resize while minimized #17559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
bug
os-windows
customer-priority
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Nov 20, 2024
|
Has #13300 (which the original changes fixed) been retested with these changes? |
Absolutely! In fact the code from that issue was used as a basis for testing the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
On Windows, this PR fixes the window's bounds being incorrectly changed if
WindowImpl.Resize()gets called while the window is minimized (this can happen as a result ofInvalidateMeasure()). This issue was introduced in #14470.Two things were wrong in this case: