Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate changelog and release packs for randomizer #70

Merged
merged 10 commits into from
Jul 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<!--
If making a change in the Entrance Randomizer, remember to add a changelog entry.
For for more information, read:
https://github.com/Avasam/ptle-tools/blob/main/Dolphin%20scripts/Entrance%20Randomizer/CHANGELOG.md
-->
29 changes: 29 additions & 0 deletions .github/verify_newsfragments.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import re
import sys
from os import listdir
from pathlib import Path

NEWS_TYPES = ("feature", "bugfix", "doc", "removal", "misc")

NEWS_PATTERN = re.compile(r"(\d+|\+.+)\.(" + "|".join(NEWS_TYPES) + r")\.md")

NEWSFRAGMENTS_FIR = Path(__file__).parent.parent / "Dolphin scripts" / \
"Entrance Randomizer" / "newsfragments"


def main():
invalid_filenames = [
filename for filename
in listdir(NEWSFRAGMENTS_FIR)
if not NEWS_PATTERN.fullmatch(filename)
]

if invalid_filenames:
sys.exit(
"The following newsfragments don't match the "
+ f"{NEWS_PATTERN} pattern: {invalid_filenames}",
)


if __name__ == "__main__":
main()
46 changes: 46 additions & 0 deletions .github/workflows/pack-randomizer-release.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: Pack Randomizer (Release)

on:
workflow_dispatch: # Allows manual triggers
push:
branches:
- main
paths:
# Release trigger
- "Dolphin scripts/Entrance Randomizer/CHANGELOG.md"
pull_request:
branches:
- main
paths:
# Release tooling
- "Dolphin scripts/pack-rando.ps1"
- ".github/workflows/pack-randomizer-release.yaml"

env:
PIP_DISABLE_PIP_VERSION_CHECK: 1
FORCE_COLOR: 1

jobs:
pack-randomizer:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: '& "Dolphin scripts/pack-rando.ps1" -Release'
shell: pwsh
# upload-artifact will double zip, so unpack first
# https://github.com/actions/upload-artifact/issues/39
- name: Get pack filename
id: packname
run: |
echo "packname=$(
find -name 'Entrance Randomizer v*.zip' | sed 's/\.zip$//1' | sed 's/^\.\///1'
)" >> $GITHUB_OUTPUT
- name: Extract premade archive
run: |
7z x \
'${{ steps.packname.outputs.packname }}.zip' \
-o'${{ steps.packname.outputs.packname }}'
- uses: actions/upload-artifact@v4
with:
name: ${{ steps.packname.outputs.packname }}
path: ${{ steps.packname.outputs.packname }}/*
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Typecheck
name: Tests

on:
workflow_dispatch: # Allows manual triggers
Expand Down Expand Up @@ -41,3 +41,13 @@ jobs:
- uses: jakebailey/pyright-action@v2
with:
version: ${{ steps.pyright_version.outputs.PYRIGHT_VERSION }}

verify_newsfragments:
name: Verify Newsfragments
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: python .github/verify_newsfragments.py
- run: python -m pip install towncrier
# - run: python -m towncrier check
- run: python -m towncrier build --draft --version check
22 changes: 22 additions & 0 deletions Dolphin scripts/Entrance Randomizer/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Changelog

All notable changes to the Entrance Randomizer will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). The version semantics are inspired by [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and go as follow:

```txt
Major.Minor.Patch

Major: New major feature or functionality (stays 0 until the first "stable" release)
Minor: Affects seed
Patch: Does't affect seed (assuming same settings)
```

This project uses [*towncrier*](https://towncrier.readthedocs.io/) and the changes for the upcoming release can be found in <https://github.com/Avasam/ptle-tools/blob/main/Dolphin%20scripts/Entrance%20Randomizer/newsfragments>.

To add a changelog entry, add a new file `<issue_or_pr_#>.<type>.md` to the `newsfragments` folder.
(See the different [fragment types](https://towncrier.readthedocs.io/en/latest/tutorial.html#creating-news-fragments))

<!-- towncrier release notes start -->

## 5.0.0 - 2024-07-13
8 changes: 1 addition & 7 deletions Dolphin scripts/Entrance Randomizer/lib/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,7 @@
from lib.transition_infos import transition_infos

__version = "0.4.0"
"""
Major: New major feature or functionality

Minor: Affects seed

Patch: Does't affect seed (assuming same settings)
"""
"""See CHANGELOG.md for version semantics."""
__dev_version = "local"
__version__ = f"{__version}-{__dev_version}"
print(f"Python version: {sys.version}")
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Initialized the changelog using Towncrier -- by @Avasam
18 changes: 15 additions & 3 deletions Dolphin scripts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,12 @@ Shaman Shop:
1. Use this fork of Dolphin <https://github.com/Felk/dolphin/releases>.
2. Turn on "Scripting" logs and set Verbosity to "Error" or any option below (not "Notice").
3. Download the randomizer zip file, either:
- from Discord;
- zip it yourself using `pack-rando.ps1`;
- download an unreleased [development build](https://github.com/Avasam/ptle-tools/actions/workflows/pack-randomizer.yaml?query=branch%3Amain+is%3Asuccess) (requires a GitHub account);
- latest release:
- from [#randomizer](https://discord.com/channels/334793217138622464/1083867986068254760) channel on Discord;
- [release artefacts](https://github.com/Avasam/ptle-tools/actions/workflows/pack-randomizer-release.yaml?query=branch%3Amain+is%3Asuccess+event%3Apush) (requires a GitHub account);
- development build:
- zip it yourself using `pack-rando.ps1`;
- [development builds](https://github.com/Avasam/ptle-tools/actions/workflows/pack-randomizer.yaml?query=branch%3Amain+is%3Asuccess+event%3Apush) (requires a GitHub account);
4. Open this zip file and drop "Scripts" at the root of your Dolphin installation (the location and names are important!).
5. Configurations are found in `Scripts/Entrance Randomizer/CONFIGS.py`.
6. In Dolphin, under "Scripts", click "Add new Scripts" and select `Scripts/Entrance Randomizer/__main__.py`.
Expand Down Expand Up @@ -73,3 +76,12 @@ In order to display the generated map take these steps:
3. Clone this repository.
4. Run `symlink-scripts.ps1 "<path to dolphin-scripting>"`.
5. In Dolphin, under "Scripts", click "Add new Scripts" and select `Scripts/Entrance Randomizer/__main__.py`.

#### Creating a release

This section serves as a reminder for myself. To create a new release:

1. Run [version-bump.ps1](/Dolphin%20scripts/version-bump.ps1).
2. Push to `main`. Any change to `CHANGELOG.md` should trigger a release pack.
3. Share on Discord with a link to the latest release section.
4. Unpin old version message, pin new version message.
11 changes: 10 additions & 1 deletion Dolphin scripts/pack-rando.ps1
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
param (
[switch] $Release = $False
)

$ScriptsFolder = "$PSScriptRoot\Scripts"
$RandoFolderName = 'Entrance Randomizer'
$VersionFilePath = "$ScriptsFolder\$RandoFolderName/lib/constants.py"
Expand All @@ -8,7 +12,12 @@ Copy-Item -Path "$PSScriptRoot\..\Various technical notes\transition_infos.json"
$VersionFileContent = Get-Content $VersionFilePath
$VersionLine = $VersionFileContent | Select-String -Pattern '^__version\s*=\s*".*"'
$RandoVersion = $VersionLine -replace '^\s*__version\s*=\s*"', '' -replace '".*$', ''
$DevVersion = git rev-parse --short HEAD
if ($Release) {
$DevVersion = ''
}
else {
$DevVersion = git rev-parse --short HEAD
}
$VersionFileContent -replace '^\s*__dev_version.*', "__dev_version = `"$DevVersion`"" | Set-Content $VersionFilePath

Compress-Archive -Path $ScriptsFolder -DestinationPath "$RandoFolderName v$RandoVersion-$DevVersion.zip" -Force
Expand Down
8 changes: 8 additions & 0 deletions Dolphin scripts/version-bump.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
$RandoFolderName = 'Entrance Randomizer'
$VersionFilePath = "$PSScriptRoot\$RandoFolderName/lib/constants.py"

$RandoVersion = Read-Host 'Version number (X.X.X)'
$VersionFileContent = Get-Content $VersionFilePath
$VersionFileContent -replace '^\s*__version = .*', "__version = `"$RandoVersion`"" | Set-Content $VersionFilePath

towncrier build --draft --version $RandoVersion
12 changes: 12 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -193,3 +193,15 @@ reportUnnecessaryComparison = "warning"
# Too strict
reportMissingSuperCall = "none"
reportUnusedCallResult = "none"

# Once we have multiple changelogs to maintain, see
# https://towncrier.readthedocs.io/en/latest/monorepo.html
[tool.towncrier]
directory = "Dolphin scripts/Entrance Randomizer/newsfragments"
filename = "Dolphin scripts/Entrance Randomizer/CHANGELOG.md"
issue_format = "[#{issue}](https://github.com/Avasam/ptle-tools/issues/{issue})"
package = "Entrance Randomizer"
package_dir = "Dolphin scripts"
start_string = "<!-- towncrier release notes start -->\n"
title_format = "## {version} - {project_date}"
underlines = ["", "", ""]