Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement static typing everywhere #21

Open
amitkparekh opened this issue Feb 6, 2021 · 0 comments
Open

Implement static typing everywhere #21

amitkparekh opened this issue Feb 6, 2021 · 0 comments
Labels
code quality Ensuring the codebase doesn't turn into mush documentation Improvements or additions to documentation good first issue Issues that don't require previous experience with Ayesaac

Comments

@amitkparekh
Copy link
Member

amitkparekh commented Feb 6, 2021 •
edited
Loading

Only parts of the application current use static types. While it makes no tangible difference on the function of the application, it can drastically improve the development experience as IDEs like PyCharm and VSCode use these types for catching possible errors early!

Static typing also reduces/removes the need to state the types within a doc comment.

mypy is already included as a developer dependency, but the repo needs a settings file.
@amitkparekh amitkparekh added documentation Improvements or additions to documentation code quality Ensuring the codebase doesn't turn into mush good first issue Issues that don't require previous experience with Ayesaac labels Feb 6, 2021
@amitkparekh amitkparekh mentioned this issue Feb 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Ensuring the codebase doesn't turn into mush documentation Improvements or additions to documentation good first issue Issues that don't require previous experience with Ayesaac
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amitkparekh