Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with file:// redirection on Android #16

Open
QuentinFchx opened this issue Jan 26, 2024 · 1 comment · May be fixed by #17
Open

Issue with file:// redirection on Android #16

QuentinFchx opened this issue Jan 26, 2024 · 1 comment · May be fixed by #17

Comments

@QuentinFchx
Copy link

Hi,

I stumbled upon your plugin while trying to implement oAuth flows (tough task on cordova 😰)

I really like the simplicity of your implementation, however, on Android the url is remapped to file:///android_asset/www/ (source) but it seems apps are now served from http://localhost (This is the source I found about that change). It results in a blank page with CORS issues everywhere.

Is this a legit issue or did I miss something in my app's configuration?

Thank you in advance 😄

@dpogue
Copy link
Member

dpogue commented Jan 26, 2024

oooh, that's a good catch! I'll see if I can get a fix for that going based on the hostname preferences used on newer cordova-android versions.

As an aside, there is an OAuth plugin (https://github.com/AyogoHealth/cordova-plugin-oauth) in case that's helpful to your app :)

dpogue added a commit that referenced this issue Jan 26, 2024
This needs to support the scheme/hostname prefix on newer versions of
Cordova Android.

Closes #16.
@dpogue dpogue linked a pull request Jan 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants