Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with terrakube_workspace_schedule #90

Open
BenjaminDecreusefond opened this issue Nov 28, 2024 · 4 comments
Open

Bug with terrakube_workspace_schedule #90

BenjaminDecreusefond opened this issue Nov 28, 2024 · 4 comments

Comments

@BenjaminDecreusefond
Copy link
Contributor

BenjaminDecreusefond commented Nov 28, 2024

Hi !

I just found a bug with the resource terrakube_workspace_schedule !
Step to reproduce:

  • Create a terrakube_workspace_schedule with an invalid cron expression, for instance "0 2 25 ? * * *". The apply will go well however, when you go on the UI workspace's schedule it will display a blank page and nothing more. Maybe we should check in the provider if the cron expression is valid before sending it to Terrakube ?

Regards!

@alfespa17
Copy link
Member

I am not really sure if there is any golang library that can validate if a quartz expression is correct to add something like that inside the provider code

@BenjaminDecreusefond
Copy link
Contributor Author

Maybe add a check in the API that returns an error if it is incorrect ? So you can catch it in the provider and return it

@alfespa17
Copy link
Member

@BenjaminDecreusefond
Copy link
Contributor Author

Sure ! no problem !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants