Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add terrakube_workspace_webhook resource #67

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

stanleyz
Copy link
Contributor

@stanleyz stanleyz commented Sep 3, 2024

No description provided.

@stanleyz stanleyz requested a review from alfespa17 as a code owner September 3, 2024 09:41
@stanleyz
Copy link
Contributor Author

stanleyz commented Oct 2, 2024

@alfespa17 since the new version 1.23 has released, can you please review and merge this one if no issues? Thanks.

@alfespa17
Copy link
Member

Hello @stanleyz, I think this looks good, just one small thing can you rename the resource to terrakube_workspace_webhook? in this way the new resource will have a similar name like workspace_tag_resource or workspace_variable_resource

@stanleyz stanleyz changed the title feat: add terrakube_webhook resource feat: add terrakube_workspace_webhook resource Oct 4, 2024
@stanleyz
Copy link
Contributor Author

stanleyz commented Oct 4, 2024

Hello @stanleyz, I think this looks good, just one small thing can you rename the resource to terrakube_workspace_webhook? in this way the new resource will have a similar name like workspace_tag_resource or workspace_variable_resource

updated, please check again.

@alfespa17 alfespa17 merged commit 7b3c4f1 into AzBuilder:main Oct 4, 2024
7 checks passed
@alfespa17
Copy link
Member

Thank you it looks good now

@stanleyz stanleyz deleted the feat/webhook branch October 4, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants