Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in ThaumcraftInvHelper.compareTagsRelaxed #61

Open
blackdrag opened this issue Aug 11, 2019 · 0 comments · May be fixed by #68
Open

NPE in ThaumcraftInvHelper.compareTagsRelaxed #61

blackdrag opened this issue Aug 11, 2019 · 0 comments · May be fixed by #68

Comments

@blackdrag
Copy link

I am currently playing the Stoneblock 2 modpack, which is also using Thaumcraft 6. See https://paste.dimdev.org/diyokubuya.mccrash for the exact exception as well as all versions of the involved mods. It happens when trying to start infusion crafting.

Looking at the code without debugging and assuming master is still valid for my version of the mod I do see a potential problem. The call to compareTagsRelaxed in

thaumcraft-api/ThaumcraftInvHelper.java

Line 87 in 79427c4

return (prime.getTagCompound() == null || ThaumcraftInvHelper.compareTagsRelaxed(prime.getTagCompound(),other.getTagCompound()));
is done if prime.getTagCompound() is not null. But that kind of implies to me, that other.getTagCompound() could be null. If that is the case it would indeed cause a NPE in

thaumcraft-api/ThaumcraftInvHelper.java

Line 98 in 79427c4

if (!other.hasKey(key) || !prime.getTag(key).equals(other.getTag(key))) {
for !other.hasKey(key). Maybe that is the bug, maybe not, I thought I just add it here for now.
@radioegor146 radioegor146 linked a pull request Apr 19, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ThaumcraftInvHelper.java radioegor146/thaumcraft-api
1 participant
@blackdrag