Replies: 1 comment 2 replies
-
Hello. I looks like a useful functionality! Please raise a Pull Request and try to make the code as polished as possible :)
|
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi, I wanted the ability to keep some burgs the way I want and regenerate the rest. So I went ahead and added it myself. I have the basic functionality working but there is still room for polish.
I wanted to get some thoughts on how I am implementing the change as well get some feedback.
Here is what I have so far:
In the Burgs Overview window I added a lock icon (currently does not change to unlock)
Currently it will add the burg id to a "burglock" list (similar to the anchors and burgIcons) and it adds a "lock" property set to 1.
When you regenerateBurgs, it gets a list of Lockedburgs by filtering the burgs based on the lock property, after the rest of the setup but before burgs are created, it goes through the Lockedburgs and adds them back, updating the relevant cells and states. It resets the IDs to prevent any id conflicts but the rest stays the same (except for emblems and the seed for MFCG unless it was customized)
So my questions are:
What do I need to do to push my changes?
The burglock list is unnecessary but useful for debug, should I remove it?
The lock icon doesn't unlock, should I fix that?
You can only lock from the Overview window not the Burg Editor Is that alright? (I'm going to fix that anyway actually)
Is there anything you can think of that I need to test for?
Beta Was this translation helpful? Give feedback.
All reactions