-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public function to delete objects from ADF instance #30
Comments
Yes, this is exactly how the feature should work like. |
Hey Kamil,
Thanks for your note.
1. I see what you mean, Excluded does not mean that is no longer "in
source" (they are considered to be in source), as a result "Delete not in
source" (true) will skip the deletion of them if they were present at the
target. This is not a big deal.
2. Yes, a way of explicit delete of objects in a given folder would
definitely be helpful. Again, just nice to have. This could be extended by
the object type (pipeline, dataset, etc.), recursive flag to delete
subfolders, perhaps even a pattern to match folders to delete.
We normally use ARM template deployment, and it works pretty well,
except when we need to automatically rebuild templates. There is no API for
that, and Microsoft is very slow in adding it. I know they are planning to
revamp ADF, but not sure when. We keep enquiring them for improvements
related to remote ADF calls, better workflow capabilities, ability to fail
a pipeline etc, all slated to come but no one knows when.
Anyway, nice package you have created. Well done. Probably the most
comprehensive that I have seen.
Thanks
Maciej
…On Sun, Sep 6, 2020 at 4:13 AM Kamil Nowinski ***@***.***> wrote:
Yes, this is exactly how the feature should work like.
'Excludes' property means you want to skip *deployment* of particular
(set of) object(s), but definitely won't delete any of excluded objects. As
latter property says "Delete Not in Source" - but the object is still in
the source (repo) and should NOT be removed from ADF service.
I consider exposing the method to delete some objects explicitly if
needed. Let me know if that would help in your scenario.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMI26ROGXX652GNRAKROGHLSENOE5ANCNFSM4Q4DGOVQ>
.
|
Thanks! Sounds good. I will do it as soon as I can. |
@NowinskiK @gidziu indeed, this feature will be really cool. |
It looks like when an ADF object is excluded from deployment (via the Excludes property of the options) it is still considered to be "in source" and DeleteNotInSource does not apply to it.
For instance: if a given ADF object is already in the target ADF, and if a new deployment excludes that object from deployment and DeleteNotInSource flag is set to true, the excluded object will not be deleted from the target.
I would expect it to be deleted after the deployment.
The text was updated successfully, but these errors were encountered: