Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Remove explicit parameter for location in README. All templates use r… #56

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

mattrowmsft
Copy link
Contributor

…esource group's location as default value.

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

vipul-modi and others added 30 commits September 19, 2018 13:23
…store/linux

Add linux sfmesh counter sf block store app
…Sample-2018-09-01-preview

Add SF Volume Disk Counter Sample and template
updated linux templates for visualobjects
* added windows version

* fixed network and renamed

* renamed network
* Move all updated templates to using 10.0.0.0/24 subnet.

* Add default location value for all templates set to the resource group's location.
* added the stateful one

* added the stateful one

* fix the network address prefix

* use secrets
* Update mesh_rp.base.linux.json

* Update mesh_rp.scaleout.linux.json

* Update mesh_rp.upgrade.linux.json

* Update mesh_rp.base.linux.json

* Update mesh_rp.scaleout.linux.json

* Update mesh_rp.upgrade.linux.json
…mples#48)

* Flush data to disk.

* Remove duplicate code packages in counterSFVolumeDisk
@mattrowmsft
Copy link
Contributor Author

@dkkapur FYI this is what I was mentioning last night.

@dkkapur dkkapur force-pushed the 2018-09-01-preview branch from db355e8 to e04d008 Compare December 4, 2018 23:54
@mattrowmsft mattrowmsft changed the base branch from 2018-09-01-preview to master December 5, 2018 22:16
@mattrowmsft
Copy link
Contributor Author

Rebasing this on master now that things have merged over.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants