Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle missing MC resource group on abe2e clusters #5314

Merged
merged 4 commits into from
Nov 21, 2024
Merged

fix: handle missing MC resource group on abe2e clusters #5314

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9b1c83
fix: handle missing MC resource group on abe2e clusters
Nov 21, 2024
1a27820
chore: cleanup
Nov 21, 2024
23f4c66
chore: more cleaning
Nov 21, 2024
c7c94ec
chore: typo
Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions e2e/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,16 @@ func getOrCreateCluster(ctx context.Context, t *testing.T, cluster *armcontainer
t.Logf("cluster %s already exists in rg %s\n", *cluster.Name, config.ResourceGroupName)
switch *existingCluster.Properties.ProvisioningState {
case "Succeeded":
nodeRGExists, err := isExistingResourceGroup(ctx, *existingCluster.Properties.NodeResourceGroup)
if err != nil {
return nil, fmt.Errorf("checking node resource group existence of cluster %s: %w", *cluster.Name, err)
}
if !nodeRGExists {
// we need to recreate in the case where the cluster is in the "Succeeded" provisioning state,
// though it's corresponding node resource group has been garbage collected
t.Logf("node resource group of cluster %s does not exist, will attempt to recreate", *cluster.Name)
return createNewAKSClusterWithRetry(ctx, t, cluster, config.ResourceGroupName)
}
return &existingCluster.ManagedCluster, nil
case "Creating", "Updating":
return waitUntilClusterReady(ctx, config.ResourceGroupName, *cluster.Name)
Expand Down
Loading