Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/res/elastic-san/elastic-san #1452

Open
2 tasks done
jbinko opened this issue Oct 1, 2024 · 5 comments
Open
2 tasks done

[Module Proposal]: avm/res/elastic-san/elastic-san #1452

jbinko opened this issue Oct 1, 2024 · 5 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@jbinko
Copy link

jbinko commented Oct 1, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/elastic-san/elastic-san

Module Details

Implement elasticSan, privateEndpointConnections, volumegroups, snapshots and volumes

https://learn.microsoft.com/en-us/azure/templates/microsoft.elasticsan/allversions

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

jbinko

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@jbinko jbinko added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Oct 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label Oct 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Oct 1, 2024
@matebarabas matebarabas added the Status: In Triage 🔍 Picked up for triaging by an AVM core team member label Oct 7, 2024
@matebarabas matebarabas changed the title [Module Proposal]: avm-res-elastic-san [Module Proposal]: avm/res/elastic-san/elastic-san Oct 7, 2024
@matebarabas matebarabas added the Class: Resource Module 📦 This is a resource module label Oct 7, 2024
@matebarabas
Copy link
Contributor

Hi @jbinko,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Oct 7, 2024
@jbinko
Copy link
Author

jbinko commented Oct 7, 2024

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Oct 7, 2024
@matebarabas
Copy link
Contributor

Hi @jbinko,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Oct 7, 2024
@matebarabas matebarabas moved this from Proposed to In development in AVM - Module Triage Oct 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Oct 29, 2024
@jbinko
Copy link
Author

jbinko commented Nov 5, 2024

Work in progress - "Status: Long Term ⏳"

@matebarabas matebarabas added Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Nov 8, 2024
@jbinko
Copy link
Author

jbinko commented Nov 19, 2024

Work completed. PR created: #3809 - Azure/bicep-registry-modules#3809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Status: In development
Development

No branches or pull requests

2 participants