FEAT Add image overlay converter #507
Conversation
…nsistent with other converters
…d_image_overlay_converter
…' into feat/add_image_overlay_converter
…d_image_overlay_converter
|
@microsoft-github-policy-service agree |
I will try to fix the problems by this weekend. I have an exam this Friday and I may not have time to update the code, sorry for that. |
No hurry at all! Knowing that you intend to get back to this is helpful. If that changes at any point let us know and we can figure out who can finish it up. Best of luck with your exam! |
|
Sorry for the delay, I finished last piece of final assignment last Sunday. I have updated most bugs based on comments, and plz feel free to review it. |
| base_image_path: str, | ||
| x_pos: Optional[int] = 0, | ||
| y_pos: Optional[int] = 0, | ||
| memory: Optional[MemoryInterface] = None, |
There was a problem hiding this comment.
#527 is removing the memory arg so you won't need to have this arg, but when you need to use memory you can simply do CentralMemory.get_memory_instance()
Let me know if this doesn't work or make sense.
| raise ValueError("File does not exist") | ||
|
|
||
| if x_pos < 0 or y_pos < 0: | ||
| raise ValueError("Position is out of boundary ") |
There was a problem hiding this comment.
I would split this up into two checks and have a more specific error message like "x_pos is less than 0 and therefore out of bounds.
Description
Tests and Documentation
I have made some simple test cases but not sure if I need to add more tests