FEAT: Pass arguments to http client #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems i need to shave some yaks on my side before signing the CLA. Will sign ASAP |
Let us know! Everything else looks good :) |
romanlutz
approved these changes
Nov 13, 2024
|
@microsoft-github-policy-service agree company="Adobe" |
Co-authored-by: rdheekonda <[email protected]>
…cessary ones, and related small fixes (Azure#556)
Co-authored-by: rdheekonda <[email protected]>
romanlutz
added a commit
to romanlutz/PyRIT
that referenced
this pull request
Nov 25, 2024
Co-authored-by: Raja Sekhar Rao Dheekonda <[email protected]> Co-authored-by: rdheekonda <[email protected]> Co-authored-by: Roman Lutz <[email protected]> Co-authored-by: Volkan Kutal <[email protected]> Co-authored-by: rlundeen2 <[email protected]> Co-authored-by: rlundeen2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
httpx.AsyncClientconfigurable by passing the kwargs from the HTTPTarget constructor.Note: I’m not entirely sure about the documentation; I’ve just added a comment in the example.
#553