feat: support empty free-form object #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllyW
approved these changes
Mar 25, 2024
kairu-ms
reviewed
Apr 1, 2024
| @@ -544,7 +544,7 @@ def to_cmd(self, builder, **kwargs): | |||
| model.props.append(prop) | |||
|
|
|||
| # additional properties | |||
| if self.additional_properties: | |||
| if self.additional_properties or not any([model.props, model.additional_props, model.discriminators]): | |||
There was a problem hiding this comment.
It's better to refactor the loop like this:
if self.additional_properties:
elif not any([model.props, model.additional_props, model.discriminators]):
kairu-ms
reviewed
Apr 1, 2024
| @@ -544,7 +544,7 @@ def to_cmd(self, builder, **kwargs): | |||
| model.props.append(prop) | |||
|
|
|||
| # additional properties | |||
| if self.additional_properties: | |||
| if self.additional_properties or not any([model.props, model.additional_props, model.discriminators]): | |||
There was a problem hiding this comment.
But I still have some concern, may be it's better add _patch here instead of changing this logic
aaz-dev-tools/src/aaz_dev/swagger/model/specs/_swagger_loader.py
Lines 44 to 49 in b8386be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #339