remove all hosts from global parameters (#972)

Azure · Jul 13, 2021 · e294bb0 · e294bb0
1 parent 8e79e6f
commit e294bb0
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,5 +1,15 @@
 # Change Log
 
+### 2021-07-06 - 5.8.4
+
+min Autorest core version: 3.3.0
+
+min Modelerfour version: 4.19.1
+
+**Bug Fixes**
+
+- Remove all hosts from global parameters, regardless of how many m4 sends us #972
+
 ### 2021-07-06 - 5.8.3
 
 min Autorest core version: 3.3.0

diff --git a/autorest/codegen/__init__.py b/autorest/codegen/__init__.py
@@ -84,9 +84,9 @@ def _create_code_model(self, yaml_data: Dict[str, Any], options: Dict[str, Union
                 first_req_of_first_op_of_first_grp = yaml_data["operationGroups"][0]["operations"][0]["requests"][0]
                 code_model.custom_base_url = first_req_of_first_op_of_first_grp["protocol"]["http"]["uri"]
         else:
-            dollar_host_parameter = dollar_host[0]
-            code_model.global_parameters.remove(dollar_host_parameter)
-            code_model.base_url = dollar_host_parameter.yaml_data["clientDefaultValue"]
+            for host in dollar_host:
+                code_model.global_parameters.remove(host)
+            code_model.base_url = dollar_host[0].yaml_data["clientDefaultValue"]
 
         # Create operations
         if yaml_data.get("operationGroups"):

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@autorest/python",
-    "version": "5.8.3",
+    "version": "5.8.4",
     "description": "The Python extension for generators in AutoRest.",
     "scripts": {
         "prepare": "node run-python3.js prepare.py",