Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed move of deidservice under healthcareapis #8224

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

chrisribe
Copy link
Member

@chrisribe chrisribe commented Nov 1, 2024

This is a proposed move of deidservice extension under healthcareapis


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 1, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️healthcareapis
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd healthcareapis deidservice sub group healthcareapis deidservice added

Copy link

Hi @chrisribe,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 1, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Nov 1, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Nov 1, 2024

@chrisribe chrisribe marked this pull request as ready for review November 1, 2024 17:13
@chrisribe
Copy link
Member Author

  • setup.py

Fixed! Thanks healthcareapis is a bit out of date.

@chrisribe
Copy link
Member Author

@wangzelin007 There are 2 python38 errors here but I do not know why they are failing all other python versions are passing. Could this be a transient error ?

@chrisribe
Copy link
Member Author

⚠️Azure CLI Extensions Breaking Change Test

@wangzelin007 I need a bit more information about this, is there anything else I need to do here ? Or will this simply be reviewed / approved ?

@chrisribe
Copy link
Member Author

chrisribe commented Nov 4, 2024

Related AAZ PR:
Azure/aaz#620
There are no reviewers added to this PR, can someone please add some ?

@kairu-ms
Copy link
Contributor

kairu-ms commented Nov 7, 2024

Please remove the extension in https://github.com/Azure/azure-cli-extensions/blob/main/src/index.json file as well

@chrisribe
Copy link
Member Author

chrisribe commented Nov 7, 2024

Please remove the extension in https://github.com/Azure/azure-cli-extensions/blob/main/src/index.json file as well

Oh nice catch ! Removed

Update:
I fixed the bad merge of main I did (I messed up the index.json conflict fix).
index.json looks ok now

@chrisribe
Copy link
Member Author

chrisribe commented Nov 11, 2024

azure-cli 2.66.0 is released I think we can release this PR now right ?
https://github.com/Azure/azure-cli/releases/tag/azure-cli-2.66.0
@kairu-ms, @yonzhan, @wangzelin007, @jsntcy, @zhoxing-ms,

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 13, 2024
@chrisribe
Copy link
Member Author

Ok well my index.json revert has caused issues I think I need to merge main again.
Working on that now....

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 13, 2024
@chrisribe
Copy link
Member Author

Ok well my index.json revert has caused issues I think I need to merge main again. Working on that now....
Ok fixed and rebased on main

Copy link

Commenter does not have sufficient privileges for PR 8224 in repo Azure/azure-cli-extensions

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit e508b54 into Azure:main Nov 14, 2024
21 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ healthcareapis ] : https://dev.azure.com/azclitools/release/_build/results?buildId=206113&view=results

@chrisribe chrisribe deleted the feature-move-healthcareapis branch November 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot extension/healthcare az healthcareapis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants