Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2024-12797: Upgrade cryptography-43.0.1 #30809

Closed
amaniel15 opened this issue Feb 12, 2025 · 3 comments · Fixed by #30816
Closed

CVE-2024-12797: Upgrade cryptography-43.0.1 #30809

amaniel15 opened this issue Feb 12, 2025 · 3 comments · Fixed by #30816
Assignees
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team customer-reported Issues that are reported by GitHub users external to the Azure organization. Packaging question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Security-Issue
Milestone

Comments

@amaniel15
Copy link

Describe the bug

This is the package maintainer's summary.

Issue summary: Clients using RFC7250 Raw Public Keys (RPKs) to authenticate a
server may fail to notice that the server was not authenticated, because
handshakes don't abort as expected when the SSL_VERIFY_PEER verification mode
is set.

Impact summary: TLS and DTLS connections using raw public keys may be
vulnerable to man-in-middle attacks when server authentication failure is not
detected by clients.

RPKs are disabled by default in both TLS clients and TLS servers. The issue
only arises when TLS clients explicitly enable RPK use by the server, and the
server, likewise, enables sending of an RPK instead of an X.509 certificate
chain. The affected clients are those that then rely on the handshake to
fail when the server's RPK fails to match one of the expected public keys,
by setting the verification mode to SSL_VERIFY_PEER.

Clients that enable server-side raw public keys can still find out that raw
public key verification failed by calling SSL_get_verify_result(), and those
that do, and take appropriate action, are not affected. This issue was
introduced in the initial implementation of RPK support in OpenSSL 3.2.

The FIPS modules in 3.4, 3.3, 3.2, 3.1 and 3.0 are not affected by this issue.

Issue summary: Clients using RFC7250 Raw Public Keys (RPKs) to authenticate a
server may fail to notice that the server was not authenticated, because
handshakes don't abort as expected when the SSL_VERIFY_PEER verification mode
is set.

Impact summary: TLS and DTLS connections using raw public keys may be
vulnerable to man-in-middle attacks when server authentication failure is not
detected by clients.

RPKs are disabled by default in both TLS clients and TLS servers. The issue
only arises when TLS clients explicitly enable RPK use by the server, and the
server, likewise, enables sending of an RPK instead of an X.509 certificate
chain. The affected clients are those that then rely on the handshake to
fail when the server's RPK fails to match one of the expected public keys,
by setting the verification mode to SSL_VERIFY_PEER.

Clients that enable server-side raw public keys can still find out that raw
public key verification failed by calling SSL_get_verify_result(), and those
that do, and take appropriate action, are not affected. This issue was
introduced in the initial implementation of RPK support in OpenSSL 3.2.

The FIPS modules in 3.4, 3.3, 3.2, 3.1 and 3.0 are not affected by this issue.

Related command

N/A

Errors

N/A

Issue script & Debug output

N/A

Expected behavior

CVE to be addressed by upgrading the decependancy

Environment Summary

azure-cli 2.69.0

core 2.69.0
telemetry 1.1.0

Dependencies:
msal 1.31.2b1
azure-mgmt-resource 23.1.1

Python location '/opt/az/bin/python3'
Config directory '/root/.azure'
Extensions directory '/root/.azure/cliextensions'

Python (Linux) 3.12.8 (main, Feb 5 2025, 06:40:26) [GCC 13.3.0]

Additional context

This issue was discovered by Aikido Security and the recommened fix is uprading to 44.0.1.

Image

@amaniel15 amaniel15 added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Feb 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 12, 2025
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 12, 2025

Thank you for opening this issue, we will look into it.

Copy link

This issue is related to security. Please pay attention.

@yonzhan yonzhan added Packaging Azure CLI Team The command of the issue is owned by Azure CLI team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that and removed bug This issue requires a change to an existing behavior in the product in order to be resolved. labels Feb 12, 2025
@yonzhan yonzhan added this to the Backlog milestone Feb 12, 2025
@bebound
Copy link
Contributor

bebound commented Feb 13, 2025

Dependabot also found this CVE but failed to create the fix PR: https://github.com/Azure/azure-cli/security/dependabot/91

After retrying, it created #30816. We'll merge it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team customer-reported Issues that are reported by GitHub users external to the Azure organization. Packaging question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Security-Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants